Skip to content

[Devtools week] Add OWNERS file#25

Merged
thepetk merged 6 commits intodevfile:mainfrom
thepetk:ft/update_owners_file
Sep 14, 2023
Merged

[Devtools week] Add OWNERS file#25
thepetk merged 6 commits intodevfile:mainfrom
thepetk:ft/update_owners_file

Conversation

@thepetk
Copy link
Contributor

@thepetk thepetk commented Sep 12, 2023 •
edited
Loading

What does this PR do?

  • Creates an OWNERS file with all devfiles team members included
  • Updates the Readme.md by explicitly mention the frequency and the way the releases are created for alizer.

Which issue(s) does this PR fix

This task is part of devtools week

PR acceptance criteria

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Unit/Functional tests

  • Documentation

How to test changes / Special notes to the reviewer

@thepetk thepetk self-assigned this Sep 12, 2023
@thepetk thepetk changed the title Add OWNERS file [Devtools week] Add OWNERS file Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (04361c9) 67.23% compared to head (ccfa770) 67.23%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #25   +/-   ##
=======================================
  Coverage   67.23%   67.23%           
=======================================
  Files          11       11           
  Lines        1419     1419           
=======================================
  Hits          954      954           
  Misses        405      405           
  Partials       60       60

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

michael-valdron
michael-valdron approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Sep 12, 2023
@thepetk
Copy link
Contributor Author

thepetk commented Sep 12, 2023

@michael-valdron I've updated your review status as I added a minor change for release process to the readme.md

michael-valdron
michael-valdron approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 12, 2023
maysunfaisal
maysunfaisal reviewed Sep 12, 2023
View reviewed changes
@michael-valdron michael-valdron mentioned this pull request Sep 12, 2023
Merged
3 tasks
@openshift-ci openshift-ci bot removed the lgtm label Sep 14, 2023
feloy
feloy reviewed Sep 14, 2023
View reviewed changes
@thepetk thepetk requested a review from feloy September 14, 2023 13:54
feloy
feloy reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed a little typo.

LGTM otherwise

thepetk and others added 6 commits September 14, 2023 15:04
@thepetk
Add OWNERS file
d6592c7 
Signed-off-by: thepetk <[email protected]>
@thepetk
Mention frequency of releases
dd218f5 
Signed-off-by: thepetk <[email protected]>
@thepetk
Reduce members inside owners file
d94731c 
Signed-off-by: thepetk <[email protected]>
@thepetk
Update readme.md
c0a0a0f 
Signed-off-by: thepetk <[email protected]>
@thepetk
Update release process instructions
a4f2e17 
Signed-off-by: thepetk <[email protected]>
@thepetk @feloy
Update README.md
ccfa770 
Co-authored-by: Philippe Martin <[email protected]>
Signed-off-by: thepetk <[email protected]>
@thepetk thepetk force-pushed the ft/update_owners_file branch from e01045b to ccfa770 Compare September 14, 2023 14:04
@thepetk thepetk requested a review from feloy September 14, 2023 14:05
@thepetk
Copy link
Contributor Author

thepetk commented Sep 14, 2023

Fixed a little typo.

LGTM otherwise

@feloy fix committed :)

feloy
feloy approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 14, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: feloy, michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 9923567 into devfile:main Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-valdron michael-valdron michael-valdron approved these changes

@elsony elsony Awaiting requested review from elsony

@yangcao77 yangcao77 Awaiting requested review from yangcao77

@maysunfaisal maysunfaisal Awaiting requested review from maysunfaisal

+1 more reviewer

@feloy feloy feloy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@feloy feloy

@thepetk thepetk

@michael-valdron michael-valdron

Labels

lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thepetk @feloy @michael-valdron @maysunfaisal