[Devtools week] Fix nightly run check after wildfly stack update#27
Merged
thepetk merged 1 commit intodevfile:mainfrom Sep 18, 2023
Merged
[Devtools week] Fix nightly run check after wildfly stack update#27thepetk merged 1 commit intodevfile:mainfrom
thepetk merged 1 commit intodevfile:mainfrom
Conversation
Signed-off-by: thepetk <[email protected]>
thepetk
changed the title
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage 67.23% 67.23%
=======================================
Files 11 11
Lines 1419 1419
=======================================
Hits 954 954
Misses 405 405
Partials 60 60
☔ View full report in Codecov by Sentry. |
rm3l
approved these changes
Sep 18, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR simply replaces a repo used by the nightly run. More detailed when the job checks for
wildfly-bootable-jarstack we use the examples/authentication source code instead of the wildfly-devfile-examples. This way we won't use the same repo for bothwildflyandwildfly-bootable-jarstacks asstarterProjectto match the given devfiles.Which issue(s) does this PR fix
fixes devfile/api#1248
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer