Rollback go and controller runtime versions#29
Merged
thepetk merged 3 commits intodevfile:v1.1.5bfrom Sep 20, 2023
Merged
Conversation
* Rollback go and controller runtime versions Signed-off-by: thepetk <[email protected]> * Update workflows versions Signed-off-by: thepetk <[email protected]> * Add warning for backported version Signed-off-by: thepetk <[email protected]> * Rollback version of multierr Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: thepetk <[email protected]>
thepetk
added a commit
that referenced
this pull request
Oct 4, 2023
* Rollback go and controller runtime versions (#16) * Rollback go and controller runtime versions Signed-off-by: thepetk <[email protected]> * Update workflows versions Signed-off-by: thepetk <[email protected]> * Add warning for backported version Signed-off-by: thepetk <[email protected]> * Rollback version of multierr Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]> * Update go version to 1.19 Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]>
thepetk
added a commit
that referenced
this pull request
Oct 4, 2023
* Rollback go and controller runtime versions (#16) * Rollback go and controller runtime versions Signed-off-by: thepetk <[email protected]> * Update workflows versions Signed-off-by: thepetk <[email protected]> * Add warning for backported version Signed-off-by: thepetk <[email protected]> * Rollback version of multierr Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]> * Update go version to 1.19 Signed-off-by: thepetk <[email protected]> --------- Signed-off-by: thepetk <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates temporary backported version of alizer using sigs.k8s.io/controller-runtime v0.14.4 in order to be tested and adopted by Hybrid Application Service.
Which issue(s) does this PR fix
N/A
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer