Include version to binaries of each release#32
Conversation
Signed-off-by: thepetk <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 70.49% 70.49%
=======================================
Files 11 11
Lines 1566 1566
=======================================
Hits 1104 1104
Misses 395 395
Partials 67 67 ☔ View full report in Codecov by Sentry. |
Signed-off-by: thepetk <[email protected]>
There was a problem hiding this comment.
LGTM, but while you're at it, I was wondering if you could also add a .exe extension to the Windows binary? Otherwise, as I just tried it on Windows 11, the file looks suspicious when downloaded by the browser and does not appear as executable by default.
(But this can be handled in a separate issue if you prefer).
Signed-off-by: thepetk <[email protected]>
Nice catch! I've added a commit to add the ".exe" extension for the windows binary. An example can be found here: https://github.com/thepetk/devfile-alizer/releases/tag/v1.1.1 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
What does this PR do?
This PR adds a the version of every release into each binary name generated from
release.yaml.Which issue(s) does this PR fix
fixes devfile/api#1212
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer
An example run of the updated action can be found here: https://github.com/thepetk/devfile-alizer/releases/tag/v1.1.0