Proposal for Devfile port detection and default ports support#33
Merged
thepetk merged 7 commits intodevfile:mainfrom Oct 26, 2023
Merged
Proposal for Devfile port detection and default ports support#33thepetk merged 7 commits intodevfile:mainfrom
thepetk merged 7 commits intodevfile:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=======================================
Coverage 70.49% 70.49%
=======================================
Files 11 11
Lines 1566 1566
=======================================
Hits 1104 1104
Misses 395 395
Partials 67 67 ☔ View full report in Codecov by Sentry. |
thepetk
force-pushed
the
ft/create_default_ports_proposal
branch
from
714cff2 to
cfe0a7b
Compare
1 task
thepetk
force-pushed
the
ft/create_default_ports_proposal
branch
from
4ff990b to
8e25ebc
Compare
rm3l
approved these changes
Oct 26, 2023
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]> Co-authored-by: Armel Soro <[email protected]> Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]>
Signed-off-by: thepetk <[email protected]> Co-authored-by: Armel Soro <[email protected]> Signed-off-by: thepetk <[email protected]>
thepetk
force-pushed
the
ft/create_default_ports_proposal
branch
from
c5b63ab to
3f577c9
Compare
rm3l
approved these changes
Oct 26, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rm3l, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a proposal document inside
docs/proposalsregarding thedevfileport detection process and the support ofdefault ports.Which issue(s) does this PR fix
fixes devfile/api#1155
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer