Merged
Conversation
Goooler
reviewed
Jan 16, 2024
Member
Goooler
left a comment
Goooler
left a comment
There was a problem hiding this comment.
Thanks for the great PR! Can you add Maven support as well?
Contributor
Author
Thanks for the suggestion! Added in the last commit. |
Goooler
reviewed
Jan 17, 2024
plugin-gradle/src/test/java/com/diffplug/gradle/spotless/GoGradleTest.java
Outdated
Show resolved
Hide resolved
# Conflicts: # CHANGES.md # plugin-maven/CHANGES.md # plugin-maven/src/main/java/com/diffplug/spotless/maven/AbstractSpotlessMojo.java
Goooler
approved these changes
Jan 18, 2024
CHANGES.md
Outdated
| ## [Unreleased] | ||
| ### Added | ||
| * Maven - Support for formatting shell scripts via [shfmt](https://github.com/mvdan/sh). ([#1998](https://github.com/diffplug/spotless/pull/1998)) | ||
| * Support for `gofmt` ([#2001](https://github.com/diffplug/spotless/issues/2001)) |
Member
There was a problem hiding this comment.
Suggested change
| * Support for `gofmt` ([#2001](https://github.com/diffplug/spotless/issues/2001)) | |
| * Support for `gofmt` ([#2001](https://github.com/diffplug/spotless/pull/2001)) |
Member
There was a problem hiding this comment.
Just forgot to rename this to pull.
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright 2016-2023 DiffPlug | |||
| * Copyright 2016-2024 DiffPlug | |||
Member
|
Thanks for a great PR! |
Member
|
Shipped in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #861