fix(tracing): Add missing attributes in vercel-ai spans by isaacs · Pull Request #18333 · getsentry/sentry-javascript

isaacs · 2025-11-26T07:02:20Z

Fix JS-1216

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

If you've added code that should be tested, please add tests.
Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

linear · 2025-11-26T07:02:24Z

JS-1216 JS Vercel AI SDK - attributes missing

Fix JS-1216

packages/core/src/tracing/vercel-ai/index.ts

github-actions · 2025-11-26T07:10:46Z

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	24.8 kB	-	-
@sentry/browser - with treeshaking flags	23.31 kB	-	-
@sentry/browser (incl. Tracing)	41.54 kB	-	-
@sentry/browser (incl. Tracing, Profiling)	46.13 kB	-	-
@sentry/browser (incl. Tracing, Replay)	79.96 kB	-	-
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	69.68 kB	-	-
@sentry/browser (incl. Tracing, Replay with Canvas)	84.64 kB	-	-
@sentry/browser (incl. Tracing, Replay, Feedback)	96.88 kB	-	-
@sentry/browser (incl. Feedback)	41.48 kB	-	-
@sentry/browser (incl. sendFeedback)	29.49 kB	-	-
@sentry/browser (incl. FeedbackAsync)	34.47 kB	-	-
@sentry/react	26.52 kB	-	-
@sentry/react (incl. Tracing)	43.74 kB	-	-
@sentry/vue	29.25 kB	-	-
@sentry/vue (incl. Tracing)	43.34 kB	-	-
@sentry/svelte	24.82 kB	-	-
CDN Bundle	27.21 kB	-	-
CDN Bundle (incl. Tracing)	42.21 kB	-	-
CDN Bundle (incl. Tracing, Replay)	78.75 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback)	84.2 kB	-	-
CDN Bundle - uncompressed	79.96 kB	-	-
CDN Bundle (incl. Tracing) - uncompressed	125.34 kB	-	-
CDN Bundle (incl. Tracing, Replay) - uncompressed	241.37 kB	-	-
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	254.13 kB	-	-
@sentry/nextjs (client)	45.96 kB	-	-
@sentry/sveltekit (client)	41.9 kB	-	-
@sentry/node-core	51.27 kB	-	-
@sentry/node	159.44 kB	+0.07%	+102 B 🔺
@sentry/node - without tracing	92.85 kB	+0.01%	+1 B 🔺
@sentry/aws-serverless	108.14 kB	+0.01%	+1 B 🔺

View base workflow run

github-actions · 2025-11-26T07:12:41Z

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario	Requests/s	% of Baseline	Prev. Requests/s	Change %
GET Baseline	9,112	-	9,041	+1%
GET With Sentry	1,767	19%	1,702	+4%
GET With Sentry (error only)	6,040	66%	6,066	-0%
POST Baseline	1,196	-	1,175	+2%
POST With Sentry	591	49%	571	+4%
POST With Sentry (error only)	1,053	88%	1,021	+3%
MYSQL Baseline	3,280	-	3,261	+1%
MYSQL With Sentry	456	14%	431	+6%
MYSQL With Sentry (error only)	2,682	82%	2,664	+1%

View base workflow run

Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216

RulaKhaled

The logic lgtm, I left some quick comments. We also need to a. update tests for Vercel v5 (it's a nested folder within vercel node integration tests) and b. run yarn fix in the root folder to fix lint issues

packages/core/src/tracing/vercel-ai/index.ts

packages/core/src/tracing/vercel-ai/utils.ts

Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216

…#18333)

packages/core/src/tracing/vercel-ai/utils.ts

…i spans (#18333)

RulaKhaled

lgtm

…ercel-ai spans (#18333)

packages/core/src/tracing/vercel-ai/index.ts

Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216

isaacs · 2025-12-02T22:39:24Z

Resolved cursor and JS-1236.

Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216 Fix JS-1236

isaacs requested a review from RulaKhaled November 26, 2025 07:02

isaacs added a commit that referenced this pull request Nov 26, 2025

fix(tracing): Add missing attributes in vercel-ai spans (#18333)

830aa2e

Fix JS-1216

isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from e14c708 to 830aa2e Compare November 26, 2025 07:03

cursor bot reviewed Nov 26, 2025

View reviewed changes

packages/core/src/tracing/vercel-ai/index.ts Outdated Show resolved Hide resolved

isaacs added a commit that referenced this pull request Nov 26, 2025

fix(tracing): Add missing attributes in vercel-ai spans (#18333)

f5b9b31

Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216

isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from 830aa2e to f5b9b31 Compare November 26, 2025 22:39

RulaKhaled reviewed Nov 27, 2025

View reviewed changes

packages/core/src/tracing/vercel-ai/index.ts Outdated Show resolved Hide resolved

packages/core/src/tracing/vercel-ai/utils.ts Outdated Show resolved Hide resolved

isaacs added a commit that referenced this pull request Dec 1, 2025

fix(tracing): Add missing attributes in vercel-ai spans (#18333)

abce6f5

Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216

isaacs added a commit that referenced this pull request Dec 1, 2025

fixup! fix(tracing): Add missing attributes in vercel-ai spans (#18333)

eb68374

isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from f5b9b31 to 346d3b3 Compare December 1, 2025 23:50

isaacs added a commit that referenced this pull request Dec 1, 2025

fixup! fixup! fix(tracing): Add missing attributes in vercel-ai spans (…

346d3b3

…#18333)

sentry bot reviewed Dec 1, 2025

View reviewed changes

packages/core/src/tracing/vercel-ai/utils.ts Show resolved Hide resolved

isaacs added a commit that referenced this pull request Dec 2, 2025

fixup! fixup! fixup! fix(tracing): Add missing attributes in vercel-a…

71b949b

…i spans (#18333)

RulaKhaled approved these changes Dec 2, 2025

View reviewed changes

isaacs added a commit that referenced this pull request Dec 2, 2025

fixup! fixup! fixup! fixup! fix(tracing): Add missing attributes in v…

caa6430

…ercel-ai spans (#18333)

cursor bot reviewed Dec 2, 2025

View reviewed changes

packages/core/src/tracing/vercel-ai/index.ts Outdated Show resolved Hide resolved

isaacs added a commit that referenced this pull request Dec 2, 2025

fix(tracing): Add missing attributes in vercel-ai spans (#18333)

a181428

Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216

isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from caa6430 to a181428 Compare December 2, 2025 22:37

isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from a181428 to 8c73ce1 Compare December 2, 2025 22:39

isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from 8c73ce1 to 8f47b16 Compare December 2, 2025 23:36

isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from 8f47b16 to bf872b5 Compare December 2, 2025 23:39

isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from bf872b5 to 5e76e74 Compare December 3, 2025 00:01

fix(tracing): Add missing attributes in vercel-ai spans (#18333)

4431746

Also, sort the fields in the integration test, in order to more easily se which fields were missing/misnamed in the fixture objects. Fix JS-1216 Fix JS-1236

isaacs force-pushed the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch from 5e76e74 to 4431746 Compare December 3, 2025 15:04

isaacs merged commit 65f5006 into develop Dec 3, 2025
402 of 403 checks passed

isaacs deleted the isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing branch December 3, 2025 15:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(tracing): Add missing attributes in vercel-ai spans#18333

fix(tracing): Add missing attributes in vercel-ai spans#18333
isaacs merged 1 commit intodevelopfrom
isaacschlueter/js-1216-js-vercel-ai-sdk-attributes-missing

isaacs commented Nov 26, 2025

Uh oh!

linear bot commented Nov 26, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 26, 2025 •

edited

Loading

Uh oh!

RulaKhaled left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RulaKhaled left a comment

Uh oh!

Uh oh!

isaacs commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

isaacs commented Nov 26, 2025

Uh oh!

linear bot commented Nov 26, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

github-actions bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

node-overhead report 🧳

Uh oh!

RulaKhaled left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RulaKhaled left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

isaacs commented Dec 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Nov 26, 2025 •

edited

Loading

github-actions bot commented Nov 26, 2025 •

edited

Loading