node-api: make napi_delete_reference use node_api_basic_env#59684
Merged
nodejs-github-bot merged 6 commits intonodejs:mainfrom Sep 12, 2025
Merged
node-api: make napi_delete_reference use node_api_basic_env#59684nodejs-github-bot merged 6 commits intonodejs:mainfrom
nodejs-github-bot merged 6 commits intonodejs:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the signature of
napi_delete_referenceto accept anode_api_basic_envinstead of anapi_env, as discussed in #59583. This change reflects thatnapi_delete_referencedoes not require the environment to be in a non-GC state and aligns the API with its intended usage.node_api_basic_envas the first argument.Refs: #59583
Checklist
/cc @nodejs/node-api