Skip to content

node-api: make napi_delete_reference use node_api_basic_env#59684

Merged
nodejs-github-bot merged 6 commits intonodejs:mainfrom
JeetuSuthar:fix-napi-delete-reference-env
Sep 12, 2025
Merged

node-api: make napi_delete_reference use node_api_basic_env#59684
nodejs-github-bot merged 6 commits intonodejs:mainfrom
JeetuSuthar:fix-napi-delete-reference-env

Conversation

@JeetuSuthar
Copy link
Contributor

This PR updates the signature of napi_delete_reference to accept a node_api_basic_env instead of a napi_env, as discussed in #59583. This change reflects that napi_delete_reference does not require the environment to be in a non-GC state and aligns the API with its intended usage.

  • Updates the function signature in both the implementation and header files.
  • Refactors all internal and test usages to pass a node_api_basic_env as the first argument.

Refs: #59583

Checklist
  • PR description includes references to the issue
  • Function signature and all usages updated
  • Tests updated to match new signature

/cc @nodejs/node-api

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants