lib,src: cache ModuleWrap.hasAsyncGraph#59703
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Sep 11, 2025
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v8::Module::IsGraphAsync()traverses the dependencies to find if theycontain TLA each time.
ModuleWrap.hasAsyncGraph()caches the resultand exposes the property to JS land so that the presence of the property
module.hasAsyncGraphcan be consistent.This also allows C++ access of cached
hasAsyncGraph.This also merges the
intantiateSync/instantiateandgetNamespaceSync/getNamespaceas they are always sync.