✨ feat: new validator to check Multiple Architectures configuration#233
Merged
openshift-ci[bot] merged 2 commits intooperator-framework:masterfrom Jun 24, 2022
camilamacedo86:add-multi-arch
Merged
✨ feat: new validator to check Multiple Architectures configuration#233openshift-ci[bot] merged 2 commits intooperator-framework:masterfrom camilamacedo86:add-multi-arch
openshift-ci[bot] merged 2 commits intooperator-framework:masterfrom
camilamacedo86:add-multi-arch
Conversation
camilamacedo86
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
ryantking
suggested changes
Mar 25, 2022
Contributor
ryantking
left a comment
ryantking
left a comment
There was a problem hiding this comment.
Few changes and questions. A lot of it is stylistic stuff to make the code more readable.
camilamacedo86
changed the title
camilamacedo86
changed the title
Contributor
Author
|
Hi @ryantking, I think we have all addressed this now. |
jmrodri
requested changes
Mar 30, 2022
Member
jmrodri
left a comment
jmrodri
left a comment
There was a problem hiding this comment.
A couple suggestions and question about SO vs OS.
Contributor
Author
|
@jmrodri THANK YOU a lot. |
Contributor
|
/lgtm |
exdx
reviewed
Apr 5, 2022
|
|
||
| // loadInfraLabelsFromCSV will gather the respective labels from the CSV | ||
| func (data *multiArchValidator) loadInfraLabelsFromCSV() { | ||
| for k, v := range data.bundle.CSV.ObjectMeta.Labels { |
Contributor
There was a problem hiding this comment.
would this iteration over the map panic if there are no labels set on the CSV?
Contributor
Author
There was a problem hiding this comment.
That was a good catcher. But the label is Labels map[string]string.
So that do not panic if be nil. See: https://go.dev/play/p/VUZPduMAOIf
perdasilva
reviewed
Jun 21, 2022
bentito
reviewed
Jun 21, 2022
bentito
reviewed
Jun 21, 2022
bentito
reviewed
Jun 21, 2022
bentito
reviewed
Jun 21, 2022
bentito
reviewed
Jun 21, 2022
bentito
reviewed
Jun 21, 2022
bentito
reviewed
Jun 21, 2022
bentito
reviewed
Jun 21, 2022
bentito
reviewed
Jun 21, 2022
Co-authored-by: Brett Tofel <[email protected]>
bentito
reviewed
Jun 21, 2022
Contributor
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, dinhxuanvu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
timflannagan
added a commit
to timflannagan/operator-framework-olm
that referenced
this pull request
Jul 26, 2022
Add the commit from operator-framework/api#233 that requires the 'docker' executable to be present in order to test code paths added in that PR. Downstream CI doesn't have docker available in the CI containers, and therefore, CI will fail when running the staging API unit tests if this commit is present. Signed-off-by: timflannagan <[email protected]>
timflannagan
added a commit
to timflannagan/operator-framework-olm
that referenced
this pull request
Jul 27, 2022
Add the commit from operator-framework/api#233 that requires the 'docker' executable to be present in order to test code paths added in that PR. Downstream CI doesn't have docker available in the CI containers, and therefore, CI will fail when running the staging API unit tests if this commit is present. Signed-off-by: timflannagan <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add: new validator to check Multiarch configuration
Motivation
Help users, cis and tools verify the Multiarch configuration