@laxmikantbpandhare It seems the verify check is failing when running a git diff from the generated code. I think you may be able to fix this by running make generate and then committing the changes.

I tried that command already but did not get anything for commit.

laxmikantbhaskarpandhare@lpandhar-mac api % make generate
/Users/laxmikantbhaskarpandhare/go/src/github.com/operator-frameowrk/api/bin/controller-gen object:headerFile=./hack/boilerplate.go.txt paths=./...
laxmikantbhaskarpandhare@lpandhar-mac api % git status
On branch update-1.25
nothing to commit, working tree clean
laxmikantbhaskarpandhare@lpandhar-mac api % 

@laxmikantbpandhare it looks like the verify check is still failing based on some formatting errors. I think doing a make format may resolve these.

Ah! yeah it was still failing. I made changes to it.

Seems like the go-apidiff test is failing due to this change and can be ignored.

If there are no major objections, I would like to see #261 merge first, as it isn't clear how much work it will be to update OLM to use the new k8s and go versions.

/hold

If there are no major objections, I would like to see #261 merge first, as it isn't clear how much work it will be to update OLM to use the new k8s and go versions.

/hold

@awgreene - this will impact SDK effort operator-framework/operator-sdk#5937. @jmrodri @theishshah - Can we wait for this?

Fyi #261 is just waiting on an approve label, which should be there soon. So we won't have to wait long for that.

#261 has merged. Fyi I'm cutting a new release so that we can use that in OLM.

/hold cancel

/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awgreene, laxmikantbpandhare

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Squashed commits and rebased after merge of #261

/lgtm

/override go-apidiff

@joelanford: Overrode contexts on behalf of joelanford: go-apidiff