crds,Makefile: Bump controller-tools version to v0.9.0#263
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: timflannagan The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
timflannagan
force-pushed
the
bump-controller-tools-version
branch
from
cb8d7b4 to
b877b7c
Compare
Makefile
Outdated
| REPO = github.com/operator-framework/api | ||
| BUILD_PATH = $(REPO)/cmd/operator-verify | ||
| PKGS = $(shell go list ./... | grep -v /vendor/) | ||
| PKGS = $(shell go list ./...) |
There was a problem hiding this comment.
We don't want to exclude any vendor packages anymore?
There was a problem hiding this comment.
We removed the vendor directory from source control in #213. But I can revert this change just in case it affects local dev for whatever reason.
There was a problem hiding this comment.
:shruggle: You know better than I, but I noted we were filtering them out previously and presumed there was a reason.
| yq: $(YQ) ## Download yq locally if necessary. | ||
| $(YQ): $(LOCALBIN) | ||
| GOBIN=$(LOCALBIN) go install $(GO_INSTALL_OPTS) github.com/mikefarah/yq/v3@latest | ||
| GOBIN=$(LOCALBIN) go install $(GO_INSTALL_OPTS) github.com/mikefarah/yq/v3@$(YQ_VERSION) |
There was a problem hiding this comment.
At some point we really need to bump yq versions. v4 came out Dec 2020.
There was a problem hiding this comment.
Yeah, I agree with this. It isn't a painful change either, just need to update v3 => v4 and then update whatever queries we write out. The new syntax is great so that shouldn't be a huge deal.
There was a problem hiding this comment.
Yep. I'll create an issue for bumping this tool dependency.
timflannagan
force-pushed
the
bump-controller-tools-version
branch
from
b877b7c to
ca89b79
Compare
Signed-off-by: timflannagan <[email protected]>
|
|
||
| tidy: ## Update dependencies | ||
| $(Q)go mod tidy | ||
| $(Q)go mod vendor |
There was a problem hiding this comment.
I added this in #262 but I realize we had already removed the vendor directory for this repository so it's unneeded now.
|
/hold for Tyler |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
3 participants
Signed-off-by: timflannagan [email protected]