Refactor class decorator: this enables type_check_only support for TypedDict and NamedTuple#16469
Merged
sobolevn merged 3 commits intopython:masterfrom Nov 13, 2023
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
AlexWaygood
approved these changes
Nov 12, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
LGTM (minor comment about a docstring below)
mypy/semanal.py
Outdated
| def analyze_class_decorator_common( | ||
| self, defn: ClassDef, info: TypeInfo, decorator: Expression | ||
| ) -> None: | ||
| """Common part for all class decorators. |
Member
There was a problem hiding this comment.
Suggested change
| """Common part for all class decorators. | |
| """Common hook for applying class decorators. |
Member
Author
There was a problem hiding this comment.
Done! Thanks, except it is not a hook. By hooks we often mean things like self.plugin.get_customize_class_mro_hook(defn.fullname)
AlexWaygood
approved these changes
Nov 12, 2023
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Contributor
|
Nice! pywin32 has some named-tuples it generates dynamically but doesn't expose. https://github.com/python/typeshed/blob/main/stubs/pywin32/win32/lib/win32gui_struct.pyi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that
TypedDictandNamedTupleclasses are special cased during semantic analyzisys. They had their own logic for class-level decorators. This is fine, but we need some common ground.As a side-effect, they can now be
type_check_only!