fix(android): setTextColor is non-nullable, prevent null exception#11147
Merged
NathanWalker merged 2 commits intomainfrom Mar 28, 2026
Merged
fix(android): setTextColor is non-nullable, prevent null exception#11147NathanWalker merged 2 commits intomainfrom
NathanWalker merged 2 commits intomainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 9bc2fbf
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Pull request overview
This PR prevents an Android crash in TextBase by ensuring setTextColor(...) isn’t invoked with a null/undefined value during timing/race conditions in bindings updates.
Changes:
- Guarded the Android
colorProperty.setNativepath to avoid callingTextView.setTextColor(...)with an undefined value.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…lorProperty.setNative Agent-Logs-Url: https://github.com/NativeScript/NativeScript/sessions/bb1580df-8f26-4e42-85b4-2c73c1bc54bc Co-authored-by: NathanWalker <[email protected]>
CatchABus
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setTextColormethod is only called with a defined value, preventing crashes based on timing/racePrevents innocent app crash due to bindings update timing (often on page navigations):
This occurs because
this.nativeTextViewProtected.setTextColor(value)is not nullable.https://android.googlesource.com/platform/frameworks/base/+/refs/heads/main/core/java/android/widget/TextView.java#5602