Skip to content

Final#2

Open
seagreenmedia wants to merge 3 commits intoReturn-Ready-2021-JavaScript-Evening:mainfrom
seagreenmedia:main
Open

Final#2
seagreenmedia wants to merge 3 commits intoReturn-Ready-2021-JavaScript-Evening:mainfrom
seagreenmedia:main

Conversation

@seagreenmedia
Copy link
Copy Markdown

No description provided.

@seagreenmedia seagreenmedia changed the title Close Final Dec 24, 2020
@seagreenmedia seagreenmedia reopened this Dec 24, 2020
@kburd kburd self-requested a review December 28, 2020 18:19
Copy link
Copy Markdown

@kburd kburd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just make sure you don't change the function names (89%)

}

append(original, value){return original;}
isEmpty(array) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isEmpty() does not work (-11)

}

subArray(original, from, to){return original;}
getClone(original) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solution works, make sure you don't change the function name though

class ArrayUtils {

isEmpty(array){return false;}
constructor(original, array, value) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for a constructor

}

indexOf(original, value){return -1;}
fillArray(original, value) {
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indexOf() and remove() work, make sure you know how to do them manually as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants