sorry.. forgot to pull request#3
sorry.. forgot to pull request#3Denae716 wants to merge 10 commits intoReturn-Ready-2021-JavaScript-Evening:mainfrom
Conversation
kburd
left a comment
There was a problem hiding this comment.
Make sure you are running the functions before you submit. A lot of these functions had misspellings that prevented me from running initially. (49%)
| isEmpty(array){return false;} | ||
|
|
||
| append(original, value){return original;} | ||
| isEmpty(array){ |
There was a problem hiding this comment.
There is no else case here, your solution does not return if it is empty (-3)
| } | ||
| } | ||
|
|
||
| append(original, value){ |
There was a problem hiding this comment.
This is an infinite loop, each time you add an element, the length goes up. This will happen each iteration. (-3)
| return original | ||
| } | ||
|
|
||
| clone(original){return original;} |
There was a problem hiding this comment.
Returns a string instead of an array (-6)
| return array | ||
| } | ||
|
|
||
| subArray(original, from, to){return original;} |
There was a problem hiding this comment.
Does not compile, from and to are indexed as arrays. from and to are numbers that represent a start and stop indices. (-11)
| } | ||
| } | ||
|
|
||
| fill(original, value){} |
There was a problem hiding this comment.
Should not be adding elements to an array, should be updating the existing values (-11)
| indexOf(original, value){return -1;} | ||
| } | ||
|
|
||
| remove(original, value){return original;} |
There was a problem hiding this comment.
Close, Hint: indexOf([4,5,6,7,8,9,10], 6) should return 2 (-3)
|
|
||
| } | ||
|
|
||
| reverse(original){} |
There was a problem hiding this comment.
Does not work, take a look and see if your if statement is correctly locating the value (-11)
| } | ||
|
|
||
|
|
||
| reverse(original){ |
No description provided.