fix Promise.finally() to return new promise via .then()#1696
Merged
Perryvw merged 3 commits intoTypeScriptToLua:masterfrom Mar 28, 2026
Merged
fix Promise.finally() to return new promise via .then()#1696Perryvw merged 3 commits intoTypeScriptToLua:masterfrom
Perryvw merged 3 commits intoTypeScriptToLua:masterfrom
Conversation
Remove redundant tests that relied on synchronous polyfill behavior differing from JS. Keep only the identity check which matches JS.
…rough Fix issue reference (TypeScriptToLua#1660, not TypeScriptToLua#1659).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1660
Promise.finally()was using afinallyCallbacksarray and returningthis, which breaks reference identity (p1.finally() === p1wastrue) and doesn't match the ES spec.Rewrites
finally()to delegate to.then(), which:finallyCallbacksfield and its handling ininvokeCallbacksAdded tests for identity, value preservation, and rejection passthrough.