Skip to content

fix Number constants #1698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RealColdFry wants to merge 1 commit into
base: master
Choose a base branch
from
+58 −21
Open

fix Number constants #1698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 43 additions & 12 deletions src/transformation/builtins/number.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,31 +77,62 @@ export function transformNumberProperty(
node
);
case "MIN_VALUE":
// 2 ^ -1074 = 5e-324 (smallest positive double)
return lua.createBinaryExpression(
lua.createNumericLiteral(-2),
lua.createNumericLiteral(1074),
lua.createNumericLiteral(2),
lua.createNumericLiteral(-1074),
lua.SyntaxKind.PowerOperator,
node
);
case "MIN_SAFE_INTEGER":
return lua.createBinaryExpression(
lua.createNumericLiteral(-2),
lua.createNumericLiteral(1074),
lua.SyntaxKind.PowerOperator,
// -(2 ^ 53 - 1) = -9007199254740991
return lua.createUnaryExpression(
lua.createParenthesizedExpression(
lua.createBinaryExpression(
lua.createBinaryExpression(
lua.createNumericLiteral(2),
lua.createNumericLiteral(53),
lua.SyntaxKind.PowerOperator
),
lua.createNumericLiteral(1),
lua.SyntaxKind.SubtractionOperator
)
),
lua.SyntaxKind.NegationOperator,
node
);
case "MAX_SAFE_INTEGER":
// 2 ^ 53 - 1 = 9007199254740991
return lua.createBinaryExpression(
lua.createNumericLiteral(2),
lua.createNumericLiteral(1024),
lua.SyntaxKind.PowerOperator,
lua.createBinaryExpression(
lua.createNumericLiteral(2),
lua.createNumericLiteral(53),
lua.SyntaxKind.PowerOperator
),
lua.createNumericLiteral(1),
lua.SyntaxKind.SubtractionOperator,
node
);
case "MAX_VALUE":
// (2 - 2 ^ -52) * 2 ^ 1023 = 1.7976931348623157e+308
return lua.createBinaryExpression(
lua.createNumericLiteral(2),
lua.createNumericLiteral(1024),
lua.SyntaxKind.PowerOperator,
lua.createParenthesizedExpression(
lua.createBinaryExpression(
lua.createNumericLiteral(2),
lua.createBinaryExpression(
lua.createNumericLiteral(2),
lua.createNumericLiteral(-52),
lua.SyntaxKind.PowerOperator
),
lua.SyntaxKind.SubtractionOperator
)
),
lua.createBinaryExpression(
lua.createNumericLiteral(2),
lua.createNumericLiteral(1023),
lua.SyntaxKind.PowerOperator
),
lua.SyntaxKind.MultiplicationOperator,
node
);

Expand Down
24 changes: 15 additions & 9 deletions test/unit/builtins/numbers.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,17 +212,23 @@ test.each(["42", "undefined"])("prototype call on nullable number (%p)", value =
});

test.each([
"Number.NEGATIVE_INFINITY <= Number.MIN_VALUE",
"Number.MIN_VALUE <= Number.MIN_SAFE_INTEGER",

"Number.MAX_SAFE_INTEGER <= Number.MAX_VALUE",
"Number.MAX_VALUE <= Number.POSITIVE_INFINITY",
// Full ordering: NEG_INF < MIN_SAFE < 0 < MIN_VALUE < EPSILON < MAX_SAFE < MAX_VALUE < POS_INF
"Number.NEGATIVE_INFINITY < Number.MIN_SAFE_INTEGER",
"Number.MIN_SAFE_INTEGER < 0",

"0 < Number.EPSILON",
"0 < Number.MIN_VALUE",
"Number.MIN_VALUE < Number.EPSILON",
"Number.EPSILON < Number.MAX_SAFE_INTEGER",
])("Numer constants have correct relative sizes (%p)", comparison => {
util.testExpression(comparison).expectToEqual(true);
"Number.MAX_SAFE_INTEGER < Number.MAX_VALUE",
"Number.MAX_VALUE < Number.POSITIVE_INFINITY",

// Verify specific values
"Number.MIN_VALUE > 0",
"Number.MIN_SAFE_INTEGER === -(2**53 - 1)",
"Number.MAX_SAFE_INTEGER === 2**53 - 1",
"Number.MAX_SAFE_INTEGER + 1 !== Number.MAX_SAFE_INTEGER",
"Number.MIN_SAFE_INTEGER - 1 !== Number.MIN_SAFE_INTEGER",
])("Number constants have correct relative sizes (%p)", comparison => {
util.testExpression(comparison).expectToMatchJsResult();
});

// https://github.com/TypeScriptToLua/TypeScriptToLua/issues/1629
Expand Down
Loading