Add AI skill to check current repository against upstream APIs#1460
Open
timsaucer wants to merge 6 commits intoapache:mainfrom
Open
Add AI skill to check current repository against upstream APIs#1460timsaucer wants to merge 6 commits intoapache:mainfrom
timsaucer wants to merge 6 commits intoapache:mainfrom
Conversation
kevinjqliu
approved these changes
Mar 29, 2026
Contributor
kevinjqliu
left a comment
There was a problem hiding this comment.
LGTM!
love to see this, i might adopt it for other projects 😄
|
|
||
| ## Important Notes | ||
|
|
||
| - The upstream DataFusion version used by this project is specified in `crates/core/Cargo.toml` — check the `datafusion` dependency version to ensure you're comparing against the right upstream version. |
Contributor
There was a problem hiding this comment.
+1 on ensuring the right version is used
Member
Author
|
Thanks for the review @kevinjqliu ! I think this was really helpful to finding some missing functions. I'm sure we'll want to make changes to it, but I also think this is a good starting point. |
Document the full FFI type pipeline (Rust PyO3 wrapper → Protocol type → Python wrapper → ABC base class → exports → example) and catalog which upstream datafusion-ffi types are supported, which have been evaluated as not needing direct exposure, and how to check for new gaps. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Add "ffi types" to the argument-hint and description so users can invoke the skill with `/check-upstream ffi types`. Also add pipeline verification step to ensure each supported FFI type has the full end-to-end chain (PyO3 wrapper, Protocol, Python wrapper with type hints, ABC, exports). Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Section 7 (FFI Types) was incorrectly placed after the Output Format and Implementation Pattern sections. Move it to sit after Section 6 (SessionContext Methods), consistent with the other checkable areas. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
The supported FFI types list would go stale as new types are added. Replace it with a grep instruction to discover them at check time, keeping only the "evaluated and not requiring exposure" list which captures rationale not derivable from code. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
One area we sometimes fail to update in this repository as compared to our upstream
datafusionis to ensure all of the new upstream features are available via Python. This PR adds an AI agent tool to help ensure we have coverage.What changes are included in this PR?
Adds a claude code skill file. Updates the documentation.
Are there any user-facing changes?
No, no code impacted.
Context
The following PRs were all generated using this skill: