Skip to content

docs: Add Architecture Decision Records (ADR) directory#6189

Open
ntkathole wants to merge 2 commits intofeast-dev:masterfrom
ntkathole:add-architecture-decision-records
Open

docs: Add Architecture Decision Records (ADR) directory#6189
ntkathole wants to merge 2 commits intofeast-dev:masterfrom
ntkathole:add-architecture-decision-records

Conversation

@ntkathole
Copy link
Copy Markdown
Member

@ntkathole ntkathole commented Mar 28, 2026

What this PR does / why we need it:

Introduce an ADR directory (docs/adr/) to keep finalized RFC decisions version-controlled alongside the codebase. This replaces the docs/rfcs/ directory and adds 8 ADRs from approved RFCs that are still applicable to the current codebase:

  • ADR-0001: Feature Services (RFC-015)
  • ADR-0002: Component Refactor (RFC-020)
  • ADR-0003: On-Demand Transformations (RFC-021)
  • ADR-0004: Entity Join Key Mapping (RFC-023)
  • ADR-0005: Stream Transformations (RFC-036)
  • ADR-0006: Kubernetes Operator (RFC-042)
  • ADR-0007: Unified Feature Transformations (RFC-043)
  • ADR-0008: Feature View Versioning
  • ADR-0009: Contribution and Extensibility Architecture (RFC-014)
  • ADR-0010: Vector Database Integration for LLM/RAG Support (RFC-040)
  • ADR-0011: Data Quality Monitoring (RFC-027)

Also updates contribution guide and governance docs to reference the ADR directory and adds the ADR process to the RFC workflow.


Open with Devin

@ntkathole ntkathole self-assigned this Mar 28, 2026
@ntkathole ntkathole requested a review from a team as a code owner March 28, 2026 13:21
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Introduce an ADR directory (docs/adr/) to keep finalized RFC decisions
version-controlled alongside the codebase. This replaces the docs/rfcs/
directory and adds 8 ADRs from approved RFCs that are still applicable
to the current codebase:

- ADR-0001: Feature Services (RFC-015)
- ADR-0002: Component Refactor (RFC-020)
- ADR-0003: On-Demand Transformations (RFC-021)
- ADR-0004: Entity Join Key Mapping (RFC-023)
- ADR-0005: Stream Transformations (RFC-036)
- ADR-0006: Kubernetes Operator (RFC-042)
- ADR-0007: Unified Feature Transformations (RFC-043)
- ADR-0008: Feature View Versioning

Also updates contribution guide and governance docs to reference the ADR
directory and adds the ADR process to the RFC workflow.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Signed-off-by: Ambient Code Bot <[email protected]>
@ambient-code ambient-code bot force-pushed the add-architecture-decision-records branch from 6bc25cd to 165d607 Compare March 28, 2026 13:23
Copy link
Copy Markdown
Member

@franciscojavierarceo franciscojavierarceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add three more Architecture Decision Records for approved RFCs that
are still applicable to the current codebase:

- ADR-0009: Contribution and Extensibility Architecture (RFC-014)
- ADR-0010: Vector Database Integration for LLM/RAG Support (RFC-040)
- ADR-0011: Data Quality Monitoring (RFC-027)

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Signed-off-by: Ambient Code Bot <[email protected]>
@ntkathole
Copy link
Copy Markdown
Member Author

i see a few more here: https://drive.google.com/drive/folders/1msUsgmDbVBaysmhBlg9lklYLLTMk4bC3?usp=drive_link

Added few missing, Some of them are not added as those are Process/governance/documentation structure guide document, not an architectural decision. Rejected/Never finalized or approved approved or very old/not relevant for current code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants