C#: Fix inconsistent casing of Cs/CS.#21613
Open
aschackmull wants to merge 1 commit intogithub:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the casing of the C# QL import alias to CS across a few internal library/test modules, aligning with the predominant convention flagged by ql-for-ql.
Changes:
- Renamed
private import csharp as Cstoprivate import csharp as CSand updated corresponding qualifier uses. - Removed an unused
csharp as Csimport fromSsaImpl.qll.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| csharp/ql/lib/utils/test/InlineMadTest.qll | Renames Cs alias to CS in the inline MAD test language adapter. |
| csharp/ql/lib/semmle/code/csharp/dataflow/internal/SsaImpl.qll | Removes an unused csharp as Cs import in DataFlowIntegrationInput. |
| csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll | Renames Cs alias to CS in the source/sink interpretation input module. |
| csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll | Renames Cs alias to CS in variable capture internals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flagged by ql-for-ql.
CSwas more common so I went with that.