Doc: Add thumbnail for font_indexing gallery example#31367
Doc: Add thumbnail for font_indexing gallery example#31367monika-2906-git wants to merge 3 commits intomatplotlib:mainfrom
Conversation
| This example shows how the font tables relate to one another. | ||
| """ | ||
|
|
||
| # sphinx_gallery_thumbnail_path = '_static/logo2.png' |
There was a problem hiding this comment.
What does the logo have to do w/ font indexing?
There was a problem hiding this comment.
Thank you for the review @story645! I have updated the thumbnail to use sphinx_gallery_thumbnail_number = -1 which is more appropriate for this example
as it will use the last generated output. I have also rebased onto main to fix the build error.
There was a problem hiding this comment.
Why do you think that would work given the output of this PR?
There was a problem hiding this comment.
My reasoning was that in Sphinx Gallery, the thumbnail is selected from the generated outputs, and using sphinx_gallery_thumbnail_number = -1 would pick the last output. I assumed that in this ,the final output would be the most appropriate figure, and therefore a good one for the thumbnail.
There was a problem hiding this comment.
What's the output of this file?
There was a problem hiding this comment.
The output of this file is a set of visualizations showing how different font tables relate to each other in the font indexing process. It generates multiple figures as part of the example.
The final output mainly illustrates the structure between font properties rather than a single meaningful visual result. So using "sphinx_gallery_thumbnail_number = -1" may not always select the most representative figure.
If needed, I can instead choose a specific figure that better reflects the purpose of the example for the thumbnail.
|
I believe you need to rebase onto main to fix the docs build error |
98c2341 to
91abaf9
Compare
|
Fixes #17479
Added sphinx_gallery_thumbnail_path to font_indexing.py
which was missing a thumbnail in the gallery.