Skip to content

Merge branch 'main' into text-overhaul#31408

Open
QuLogic wants to merge 103 commits intomatplotlib:text-overhaulfrom
QuLogic:text-overhaul-mergeup
Open

Merge branch 'main' into text-overhaul#31408
QuLogic wants to merge 103 commits intomatplotlib:text-overhaulfrom
QuLogic:text-overhaul-mergeup

Conversation

@QuLogic
Copy link
Copy Markdown
Member

@QuLogic QuLogic commented Mar 27, 2026

PR summary

There were several conflicts and new images, so just trying to confirm that everything passes everywhere.

AI Disclosure

None

PR checklist

story645 and others added 30 commits March 3, 2026 20:22
Co-authored-by: Tim Hoffmann <[email protected]>
Co-authored-by: Ruth Comer <[email protected]>
Co-authored-by: Scott Shambaugh <[email protected]>
…31133)

* fix: resolve FigureCanvasTkAgg clipping on Windows HiDPI

* Fix lint issues

* Fix update_idletasks call in Tk backend

* Check for update_idletasks existence before calling

* refactor: fix HiDPI clipping for layout-managed FigureCanvasTkAgg by resizing with actual widget dimensions instead of computed ones after DPI changes

* fix: matplot error

* update docstring

---------

Co-authored-by: intelliking <[email protected]>
Co-authored-by: Ubuntu <[email protected]>
…s-reuse-error

API: Raise ValueError in subplots if num refers to existing figure
Co-authored-by: Elliott Sales de Andrade <[email protected]>
SEC: Block shell escapes in latex and ps commands
…origin

MNT: Restrict webagg toolbar actions to valid actions
Introduce a val_in_range method in ScaleBase to explicitly check whether
values lie within the valid domain of a scale. The default
implementation falls back to limit_range_for_scale for compatibility
with existing scales.

Specific scales (e.g., LogScale, LogitScale) override this method with
more efficient checks.
…-doc

DOC: clarify explanation of axline in infinite lines example
@QuLogic
Copy link
Copy Markdown
Member Author

QuLogic commented Mar 27, 2026

Test failures are from #31198, which updated some figures, but I didn't re-create them on this branch yet.

The wasm crash is because we no longer have the FreeType visibility patch since 2.6.1 had our own Meson build patched in and 2.14 doesn't. However, after fixing that, I'm still getting some crashes, so may have to disable wasm for a bit.

- Port FreeType symbol visibility patch to 2.14.1
- Add test image preloading to wasm CI workflow
- Temporarily disable testing `test_complex_shaping`, which triggers
  some code path that fails somehow
@QuLogic QuLogic force-pushed the text-overhaul-mergeup branch from 500f27b to 8c34645 Compare March 28, 2026 03:12
@QuLogic
Copy link
Copy Markdown
Member Author

QuLogic commented Mar 28, 2026

I pushed some fixes for the wasm CI:

  • Port FreeType symbol visibility patch to 2.14.1
  • Add test image preloading to wasm CI workflow
  • Temporarily disable testing test_complex_shaping, which triggers some code path that fails somehow

and as a corollary to #31198, I also pushed updated test images for the text-overhaul-figures branch.

@QuLogic
Copy link
Copy Markdown
Member Author

QuLogic commented Mar 28, 2026

Oops, the preloading code will always prefer the test images from the PR, so it picks up the ones from main instead and fails. You'll have to just trust the results from the commit diff or download and run locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Waiting for other PR

Development

Successfully merging this pull request may close these issues.