MNT: Minor cleanup of label formatting in PathCollection.legend_elements#31412
Open
timhoffm wants to merge 1 commit intomatplotlib:mainfrom
Open
MNT: Minor cleanup of label formatting in PathCollection.legend_elements#31412timhoffm wants to merge 1 commit intomatplotlib:mainfrom
timhoffm wants to merge 1 commit intomatplotlib:mainfrom
Conversation
jklymak
approved these changes
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls the label formatting out of the loop, so that we don't have to do set_locs() for every label.
Note that
fmtis aFormatterand thus always hasset_locs().As written in the note, I would like to simplify to
fmt.format_ticks(label_values), but that has subtly different semantics, e.g. in possibly considering an offsetText. Such a change would require a deeper understanding of the formatter logic.