Cleanup #73

Closed

WhyNotHugo wants to merge 5 commits from cleanup into master

WhyNotHugo commented

2020-05-18 22:59:01 +02:00

(Migrated from github.com)

Some minor cleanup of dead code.

codecov[bot] commented

2020-05-18 23:00:22 +02:00

(Migrated from github.com)

Codecov Report

Merging #73 into master will decrease coverage by 0.32%.
The diff coverage is 67.69%.

@@            Coverage Diff             @@
##           master      #73      +/-   ##
==========================================
- Coverage   75.12%   74.80%   -0.33%     
==========================================
  Files          15       15              
  Lines         780      770      -10     
==========================================
- Hits          586      576      -10     
  Misses        194      194

Impacted Files	Coverage Δ
barcode/__init__.py	`66.66% <ø> (ø)`
barcode/pybarcode.py	`0.00% <0.00%> (ø)`
barcode/base.py	`66.66% <37.50%> (ø)`
barcode/upc.py	`80.00% <64.28%> (-0.36%)`	⬇️
barcode/codex.py	`82.85% <72.09%> (-0.20%)`	⬇️
barcode/writer.py	`79.00% <75.00%> (ø)`
barcode/ean.py	`89.15% <76.47%> (-0.50%)`	⬇️
barcode/isxn.py	`86.27% <83.33%> (-0.52%)`	⬇️
barcode/itf.py	`93.33% <86.66%> (-0.15%)`	⬇️
barcode/charsets/code128.py	`100.00% <100.00%> (ø)`
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ed0d71...77b74f4. Read the comment docs.

# [Codecov](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73?src=pr&el=h1) Report > Merging [#73](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73?src=pr&el=desc) into [master](https://codecov.io/gh/WhyNotHugo/python-barcode/commit/1ed0d7148eb7da54d3114362b4a424513ace7722&el=desc) will **decrease** coverage by `0.32%`. > The diff coverage is `67.69%`. [![Impacted file tree graph](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73/graphs/tree.svg?width=650&height=150&src=pr&token=5jRKlKcg2C)](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #73 +/- ## ========================================== - Coverage 75.12% 74.80% -0.33% ========================================== Files 15 15 Lines 780 770 -10 ========================================== - Hits 586 576 -10 Misses 194 194 ``` | [Impacted Files](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [barcode/\_\_init\_\_.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73/diff?src=pr&el=tree#diff-YmFyY29kZS9fX2luaXRfXy5weQ==) | `66.66% <ø> (ø)` | | | [barcode/pybarcode.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73/diff?src=pr&el=tree#diff-YmFyY29kZS9weWJhcmNvZGUucHk=) | `0.00% <0.00%> (ø)` | | | [barcode/base.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73/diff?src=pr&el=tree#diff-YmFyY29kZS9iYXNlLnB5) | `66.66% <37.50%> (ø)` | | | [barcode/upc.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73/diff?src=pr&el=tree#diff-YmFyY29kZS91cGMucHk=) | `80.00% <64.28%> (-0.36%)` | :arrow_down: | | [barcode/codex.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73/diff?src=pr&el=tree#diff-YmFyY29kZS9jb2RleC5weQ==) | `82.85% <72.09%> (-0.20%)` | :arrow_down: | | [barcode/writer.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73/diff?src=pr&el=tree#diff-YmFyY29kZS93cml0ZXIucHk=) | `79.00% <75.00%> (ø)` | | | [barcode/ean.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73/diff?src=pr&el=tree#diff-YmFyY29kZS9lYW4ucHk=) | `89.15% <76.47%> (-0.50%)` | :arrow_down: | | [barcode/isxn.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73/diff?src=pr&el=tree#diff-YmFyY29kZS9pc3huLnB5) | `86.27% <83.33%> (-0.52%)` | :arrow_down: | | [barcode/itf.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73/diff?src=pr&el=tree#diff-YmFyY29kZS9pdGYucHk=) | `93.33% <86.66%> (-0.15%)` | :arrow_down: | | [barcode/charsets/code128.py](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73/diff?src=pr&el=tree#diff-YmFyY29kZS9jaGFyc2V0cy9jb2RlMTI4LnB5) | `100.00% <100.00%> (ø)` | | | ... and [5 more](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73?src=pr&el=footer). Last update [1ed0d71...77b74f4](https://codecov.io/gh/WhyNotHugo/python-barcode/pull/73?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).