Use bon for entry builder #38

Merged

AljoschaMeyer merged 3 commits from aecsocket/willow_rs:feat/bon into main

2026-04-07 20:37:03 +02:00

aecsocket commented

2026-04-07 13:49:10 +02:00

Contributor

Removes willow_data_model's EntryBuilder and makes it derived by bon instead. Keeps the custom methods like payload, async_payload. Adjusts willow25's EntryBuilder to match.

I'm not a fan of how willow25 wraps the EntryBuilder, since it means we have to manually redefine the builder setter fns, but I don't think there's much we can do.

The payload and payload_async fns convert a usize to a u64 by as-casting, which is potentially dangerous. I've kept it in but as a panicking u64::try_from().expect - imo these fns should return Results.

Removes `willow_data_model`'s `EntryBuilder` and makes it derived by `bon` instead. Keeps the custom methods like `payload`, `async_payload`. Adjusts `willow25`'s `EntryBuilder` to match. I'm not a fan of how willow25 wraps the EntryBuilder, since it means we have to manually redefine the builder setter fns, but I don't think there's much we can do. The `payload` and `payload_async` fns convert a usize to a u64 by `as`-casting, which is potentially dangerous. I've kept it in but as a panicking `u64::try_from().expect` - imo these fns should return `Result`s.

aecsocket added 1 commit

2026-04-07 13:49:11 +02:00

Use bon for entry builder 50ff0ab2b6

aecsocket added 1 commit

2026-04-07 14:57:50 +02:00

address panicking path in payload serial 144b3e2db3

AljoschaMeyer commented

2026-04-07 16:47:06 +02:00

Owner

PR looks good, I'm happy to merge this after seeing all tests pass =)

The payload and payload_async fns convert a usize to a u64 by as-casting, which is potentially dangerous. I've kept it in but as a panicking u64::try_from().expect - imo these fns should return Results.

Opened a dedicated issue for this one: #40

PR looks good, I'm happy to merge this after seeing all tests pass =) > The payload and payload_async fns convert a usize to a u64 by as-casting, which is potentially dangerous. I've kept it in but as a panicking u64::try_from().expect - imo these fns should return Results. Opened a dedicated issue for this one: https://codeberg.org/worm-blossom/willow_rs/issues/40

AljoschaMeyer commented

2026-04-07 17:23:00 +02:00

Owner

@aecsocket there are a bunch of doc tests that now fail, could you fix those?

aecsocket added 1 commit

2026-04-07 18:33:38 +02:00

Allow overwriting builder methods, fix doctests 7d9bc63336