Skip to content

rough ts6 fixes to make ts happy#1701

Draft
RealColdFry wants to merge 9 commits intoTypeScriptToLua:masterfrom
RealColdFry:experiment/ts6-migration
Draft

rough ts6 fixes to make ts happy#1701
RealColdFry wants to merge 9 commits intoTypeScriptToLua:masterfrom
RealColdFry:experiment/ts6-migration

Conversation

@RealColdFry
Copy link
Copy Markdown
Contributor

@RealColdFry RealColdFry commented Mar 30, 2026 •
edited
Loading

Happy to rework any of this.

Upgrade TypeScript from 5.9.3 to 6.0.2, along with typescript-eslint 8.58.0 and ts-jest 29.4.9 so they have peer deps on TS 6.0.2

Not included here

  • Map.getOrInsert / getOrInsertComputed lualib support. Node runtime doesn't have these yet so expectToMatchJsResult in tests cannot cover them.
  • Resolver support for paths inherited from extended tsconfigs without baseUrl. Supporting that correctly means resolving each paths entry relative to the tsconfig where it is defined, not just the leaf config.

@RealColdFry
Copy link
Copy Markdown
Contributor Author

RealColdFry commented Mar 30, 2026 •
edited
Loading

things to check, all checked.

  • restore pre-compiled picomatch matchers, currently recompiling per call which is a perf regression
  • duplicate test name "in function parameter" in destructuring tests, rename one
  • verify paths-simple snapshot change, output path changed from dist/main.lua to dist/myprogram/main.lua
  • strictNullChecks: false additions in a few tests, might be masking real bugs
  • tsconfig swaps experimentalDecorators for moduleResolution bundler, does the source still build with module commonjs?
  • tsconfig.eslint.json only includes src but eslint lints tests too
  • comment on the overrides block explaining typescript-eslint doesn't support ts 6.0 yet
  • comment on ignoreDiagnostics([2783]) explaining the ts 6.0 change

@RealColdFry RealColdFry force-pushed the experiment/ts6-migration branch from 7bd6047 to 9c4606d Compare April 2, 2026 21:32
@RealColdFry RealColdFry changed the title wip: ts 6.0 migration Upgrade TypeScript to 6.0 Apr 2, 2026
@RealColdFry RealColdFry changed the title Upgrade TypeScript to 6.0 rough ts6 fixes to make ts happy Apr 2, 2026
@Perryvw Perryvw mentioned this pull request Apr 3, 2026
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RealColdFry