fix dots in file/directory names breaking Lua require resolution (#1445)#1702
Open
RealColdFry wants to merge 2 commits intoTypeScriptToLua:masterfrom
Open
fix dots in file/directory names breaking Lua require resolution (#1445)#1702RealColdFry wants to merge 2 commits intoTypeScriptToLua:masterfrom
RealColdFry wants to merge 2 commits intoTypeScriptToLua:masterfrom
Conversation
…eScriptToLua#1445) Lua's require() uses dots as path separators, so a file at Foo.Bar/index.lua is unreachable via require("Foo.Bar.index") since Lua looks for Foo/Bar/index.lua. Expand dotted path segments into nested directories in the emit output, and emit a diagnostic when this expansion causes output path collisions.
Member
|
While this is a possible solution, wouldn't it be simpler (and the output more reasonable) if we were to just find/replace periods with e.g. underscores in the output file names? |
… nested directories
Contributor
Author
Agreed, done |
Perryvw
reviewed
Apr 3, 2026
| // regardless of output path. We check the output path directly instead. | ||
| test("dots in directory names are replaced with underscores in output", () => { | ||
| const { transpiledFiles } = util.testModule` | ||
| import { answer } from "./Foo.Bar"; |
Member
There was a problem hiding this comment.
Could you also add a test where you're including a file like "Foo.Bar.ts", or maybe "foo.test.ts" since that was mentioned in the issue, rather than only directories with dots
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #1445
Lua's require() uses dots as path separators, so a file at Foo.Bar/index.lua is unreachable via require("Foo.Bar.index") since Lua looks for Foo/Bar/index.lua. Expand dotted path segments into nested directories in the emit output, and emit a diagnostic when this expansion causes output path collisions.