Forms signal minDate and maxDate validator#67544
Closed
brunoredes wants to merge 1 commit intoangular:mainfrom
Closed
Forms signal minDate and maxDate validator#67544brunoredes wants to merge 1 commit intoangular:mainfrom
brunoredes wants to merge 1 commit intoangular:mainfrom
Conversation
JeanMeche
requested changes
Mar 10, 2026
Member
JeanMeche
left a comment
There was a problem hiding this comment.
Looks like this implementation is incomplete (or at least not covered by tests).
Check out packages/forms/signals/test/web/form_field_directive.spec.ts, you'll see that min/minlength etc add the matching attribute to the dom.
This comment was marked as resolved.
This comment was marked as resolved.
7bdb742 to
15b46d2
Compare
15b46d2 to
9139ac5
Compare
Add dedicated `minDate()` and `maxDate()` validation rules for string-based date and time form fields. These validators use lexicographic string comparison, which correctly handles ISO-formatted values from `<input type="date">`, `<input type="time">`, and `<input type="datetime-local">`. Both validators support static string values, dynamic values via LogicFn, and custom error messages/functions.
9139ac5 to
f8d2abd
Compare
Member
|
This issue has been picked up by the team. #68001 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The min() and max() validators only accept numeric values as the constraint argument. When used with string paths, passing a string like '2025-06-01' results in a TypeScript error.
This prevents using these validators for date/time inputs without workarounds.
Issue Number: 151664003
What is the new behavior?
minDate()validator that validates string-based form fields (date, time, datetime-local) are greater than or equal to a given minimum string value using lexicographic comparison.maxDate()validator that validates string-based form fields (date, time, datetime-local) are less than or equal to a given maximum string value using lexicographic comparison.min()andmax().Does this PR introduce a breaking change?
Other information
Solves Experimental Signal Forms (view)