fix(core): allow explicit read generic with signal input transforms#67997
Open
cexbrayat wants to merge 1 commit intoangular:mainfrom
Open
fix(core): allow explicit read generic with signal input transforms#67997cexbrayat wants to merge 1 commit intoangular:mainfrom
cexbrayat wants to merge 1 commit intoangular:mainfrom
Conversation
Using explicit single generic arguments with transforms, e.g.
`input<boolean>(false, {transform: booleanAttribute})`, failed overload
resolution.
Before this fix, type-checking produced:
````
✘ [ERROR] TS2769: No overload matches this call.
Overload 1 of 5, '(initialValue: boolean, opts?: InputOptionsWithoutTransform<boolean> | undefined): InputSignal<boolean>', gave the following error.
Type '(value: unknown) => boolean' is not assignable to type 'undefined'.
Overload 2 of 5, '(initialValue: undefined, opts: InputOptionsWithoutTransform<boolean>): InputSignal<boolean | undefined>', gave the following error.
Argument of type 'true' is not assignable to parameter of type 'undefined'. [plugin angular-compiler]
```
Add specialized overloads for `input(...)` with transform write type equal to
read type, and add signature tests for `booleanAttribute`/`numberAttribute`
with both defined and undefined initial values.
Member
|
That would be a fix for #53969, right ? |
Member
Author
|
@JeanMeche Indeed, it looks like it is! 👍 According to the discussion between @JoostK and @devversion , maybe my fix is too naive? But maybe it is a usable workaround until TS natively support it (even if the linked PR upstream has been closed, so it might not be soon). |
Member
|
This is interesting, I hadn't considered this. Would this behave the same as specifying |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Using explicit single generic arguments with transforms, e.g.
input<boolean>(false, {transform: booleanAttribute}), failed overload resolution.Before this fix, type-checking produced:
What is the new behavior?
Add specialized overloads for
input(...)with transform write type equal to read type, and add signature tests forbooleanAttribute/numberAttributewith both defined and undefined initial values.Does this PR introduce a breaking change?
Other information