fix(language-service): Provide support for protected signal inputs#68029
Draft
atscott wants to merge 3 commits intoangular:mainfrom
Draft
fix(language-service): Provide support for protected signal inputs#68029atscott wants to merge 3 commits intoangular:mainfrom
atscott wants to merge 3 commits intoangular:mainfrom
Conversation
Add HOST_DIRECTIVE expression identifier to TCB comments to identify host directives.
…ecker This updates the SymbolBuilder to no longer use ts.TypeChecker internally to build symbols for the language service. These lookups are deferred/done later using the newly expanded template type checker API.
Protected signal inputs weren't working. now they are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
built on top of #67961 because otherwise the solution would default to using the typechecker that we're trying to remove