Add SPOG routing support for account-level vanity URLs#767
Open
msrathore-db wants to merge 1 commit intomainfrom
Open
Add SPOG routing support for account-level vanity URLs#767msrathore-db wants to merge 1 commit intomainfrom
msrathore-db wants to merge 1 commit intomainfrom
Conversation
SPOG replaces per-workspace hostnames with account-level URLs. When httpPath contains ?o=<workspaceId>, the connector now extracts the workspace ID and injects x-databricks-org-id as an HTTP header on all non-OAuth endpoints (SEA, telemetry, feature flags). Changes: - Fix warehouse ID regex to stop at query params ([^?&]+ instead of .+) - Extract ?o= from httpPath once during session init, store as _spog_headers - Propagate org-id header to telemetry client via extra_headers param - Propagate org-id header to feature flags client - Do NOT propagate to OAuth endpoints (they reject it with 400) Signed-off-by: Madhavendra Rathore <[email protected]> Co-authored-by: Isaac Signed-off-by: Madhavendra Rathore <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.+to[^?&]+to stop at query params (e.g.?o=for SPOG routing)?o=<workspaceId>fromhttpPathduring session init, injectx-databricks-org-idheader on all non-OAuth endpointsextra_headersparameter/oidc/v1/token, discovery) do NOT receive the header (they reject it with 400)Test plan
?o=query params (3 new cases intest_sea_backend.py)test_session.py)This pull request was AI-assisted by Isaac.