Draft
Conversation
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
…bleFieldPredicateEnvironment Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
…ity, GraphqlFieldVisibility, NoIntrospectionGraphqlFieldVisibility Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Add @nullable to replacedType/replacedInterfaces/replacedWrappedType fields, nullable return types on getValue/getDataFetcher/getTypeResolver methods, and fix cascading nullability in GraphQLSchema and Anonymizer. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
# Conflicts: # src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
Test ReportTest Results
|
TreeParallelTransformer only set List.class as a context var but never NodeAdapter.class. After JSpecify annotations wrapped getVar() calls with assertNotNull(), this caused test failures in TreeParallelTransformerTest and AstTransformerTest. Co-Authored-By: Claude Opus 4.6 <[email protected]>
dondonz
commented
Mar 7, 2026
| public void compute() { | ||
| currentContext.setPhase(TraverserContext.Phase.ENTER); | ||
| currentContext.setVar(List.class, myZippers); | ||
| currentContext.setVar(NodeAdapter.class, nodeAdapter); |
Member
Author
There was a problem hiding this comment.
Another interesting bugfix surfaced by JSpecify
# Conflicts: # .claude/commands/jspecify-annotate.md # src/main/java/graphql/execution/ExecutionContext.java # src/main/java/graphql/introspection/GoodFaithIntrospection.java # src/main/java/graphql/normalized/ExecutableNormalizedOperation.java # src/test/groovy/graphql/archunit/JSpecifyAnnotationsCheck.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over 120 new JSpecify annotated classes in this PR.
Don't review this yet - there's a bunch of other JSpecify PRs that need to be merged in first, and I need to closely check all of these classes again. Opening this PR to let you know it's here.
This branch is branching off the "big wave 3" branch but I'm targeting master so this diff looks very odd.
If this PR is too large and hard to read after all the others get merged in, I'm happy to split this into smaller PRs.
There are only ~10 classes left to annotate after this PR.