Fix build errors on Mac OSX 10.8#2
Open
ville-k wants to merge 1 commit intohypertable:masterfrom
ville-k:master
Open
Fix build errors on Mac OSX 10.8#2ville-k wants to merge 1 commit intohypertable:masterfrom ville-k:master
ville-k wants to merge 1 commit intohypertable:masterfrom
ville-k:master
Conversation
* access Blob::size member variable instead of calling non-existent function Blob::size() * specify template base class (Allocator) when calling it's functions from a subclass * remove duplicate declaration of a function and change the declaration to use correct type * wrap overloaded std::string operators inside the std namespace
3e1bbf7 to
a42b3e1
Compare
c7bd5de to
dcfe39d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes fix build errors (but not warnings) on OSX 10.8 with compiler:
Only one (Blob::size vs Blob::size()) of the fixed build errors looked worrisome.
calling non-existent function Blob::size()
calling it's functions from a subclass
change the declaration to use correct type
std namespace