This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Player ]] Update Windows player control to use MediaFoundation#7358
Open
livecodeian wants to merge 8 commits intolivecode:developfrom
Open
[[ Player ]] Update Windows player control to use MediaFoundation#7358livecodeian wants to merge 8 commits intolivecode:developfrom
livecodeian wants to merge 8 commits intolivecode:developfrom
Conversation
added 2 commits
May 14, 2020 15:19
…undation This patch replaces the current DirectShow-based windows media player implementation with one based on the MediaFoundation API
added 6 commits
May 15, 2020 15:48
This patch modifies the track media type property to return an enumeration value instead of a string, in order to ensure that the media type string used in the track list is consistent between platforms.
This patch changes the return type of player track offset and duration properties to MCPlatformPlayerDuration as these values may overflow the current uint32_t return type
This patch implements the underlying platform player API functions used to provide the 'tracks', 'trackCount', and 'enabledTracks' properties of player objects
…acks This patch reduces the work done by platform players when setting the enabledTracks property by only changing the enabled state of tracks added or removed from the enabledTracks. This is useful for some player implementations (e.g. Windows MediaFoundation) which need to reload the media source when enabling or disabling tracks.
This patch updates the dictionary entries for the "enabedTracks", "trackCount", "tracks", and "loadedTime" properties to show that the support for these properties has changed on Windows due to the switch to MediaFoundation. In addition, references to QuickTime have been removed as these are now obsolete.
This patch adds a release note for the change of implementation in the Windows player control from DirectShow to MediaFoundation.
e12584d to
88e8f9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch replaces the current windows player control implementation with one based on the MediaFoundation API.
The primary motivation for this update is the lack of support in DirectShow for newer file formats and inconsistencies in support for certain features such as non-standard playback rates and mirrored video playback.
The "tracks", "trackCount", and "enabledTracks" properties are now supported in the player control.
The "loadedTime" property is no longer supported"