MNT: Privatize Formatter attributes#31416
Draft
timhoffm wants to merge 1 commit intomatplotlib:mainfrom
Draft
Conversation
e4c6d63 to
fec1f04
Compare
fec1f04 to
7059dc8
Compare
7059dc8 to
310092b
Compare
QuLogic
reviewed
Mar 30, 2026
Member
QuLogic
left a comment
There was a problem hiding this comment.
Many internal uses are still not fixed and breaking tests/docs, so I'll mark this as draft.
| '%Y-%b-%d', | ||
| '%Y-%b-%d %H:%M'] | ||
| self.offset_string = '' | ||
| self._offset_string = '' |
Member
There was a problem hiding this comment.
There are still all the internal users of this that aren't converted and will raise a warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These attributes are internal state and users should not access them:
ScalarFormatter.orderOfMagnitude
ScalarFormatter.format
ConciseDateFormatter.offset_format
Formatter.locs
Making them private will allow rearchitecting the handling of tick context (i.e. information extracted from a group of ticks, that may influence their formatting) in the future.
This works towards #31396.