Set default start_with_request to yes and remove the "default" option#34
Open
carlos-granados wants to merge 2 commits intophp-debugger:mainfrom
Open
Set default start_with_request to yes and remove the "default" option#34carlos-granados wants to merge 2 commits intophp-debugger:mainfrom
carlos-granados wants to merge 2 commits intophp-debugger:mainfrom
Conversation
pronskiy
reviewed
Apr 2, 2026
xdebug.c
Outdated
| #endif | ||
|
|
||
| static const char *xdebug_start_with_request_types[5] = { "", "default", "yes", "no", "trigger" }; | ||
| static const char *xdebug_start_with_request_types[5] = { "", "yes", "no", "trigger" }; |
src/lib/lib.c
Outdated
Comment on lines
483
to
492
| if (trigger_name) { | ||
| xdebug_log(XLOG_CHAN_CONFIG, XLOG_INFO, "Trigger value for 'XDEBUG_TRIGGER' not found, falling back to '%s'", trigger_name); | ||
| trigger_value = xdebug_lib_find_in_globals(trigger_name, &found_in_global); | ||
| } | ||
|
|
||
| /* Also try PHP_DEBUGGER_SESSION alias */ | ||
| if (!trigger_value && XDEBUG_MODE_IS(XDEBUG_MODE_STEP_DEBUG) && (for_mode == XDEBUG_MODE_STEP_DEBUG)) { | ||
| if (!trigger_value) { | ||
| trigger_name = "PHP_DEBUGGER_SESSION"; | ||
| trigger_value = xdebug_lib_find_in_globals(trigger_name, &found_in_global); | ||
| } |
Collaborator
There was a problem hiding this comment.
These conditions can be simplified as I undersand, because trigger_name is always set, right?
src/lib/lib.c
Outdated
Comment on lines
+538
to
+540
| /* Returns 1 if the mode is 'trigger', or 'default', where the default mode for | ||
| * a feature is to trigger. Does not check whether a trigger is present. */ | ||
| int xdebug_lib_start_if_mode_is_trigger(int for_mode) | ||
| int xdebug_lib_start_if_mode_is_trigger() |
fbdcf59 to
2f857a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.