improve julia language support#3494
Closed
ericphanson wants to merge 8 commits intopre-commit:mainfrom
Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes three issues I ran into when trying to use pre-commit's native Julia language support for ExplicitImports.jl (JuliaTesting/ExplicitImports.jl#100) in Pkg (JuliaLang/Pkg.jl#4326):
--startup-file=noto both invocations of Julia (install & run). The startup file is a Julia script that users can configure to run commands before the start of their Julia session. It is typically used to load developer packages like Revise and not used "in-production". Here when we run our pre-commit hooks we do not want to run the user's startup file which could have dependencies the current environment does not have.srcfiles in addition to Project/Manifest. This allows pre-commit hooks to live inside a package (like https://github.com/JuliaTesting/ExplicitImports.jl/blob/main/.pre-commit-hooks.yaml) instead of being in a separate repo (like https://github.com/fredrikekre/runic-pre-commit).JULIAUP_CHANNELenvironmental variable. This support is limited in a couple ways:JULIAUP_CHANNELdoes not do anything and setting thelanguage_versionwill not have any effect. That however is the status quo (currently setting thelanguage_versiondoes not have any effect) and many users use juliaup, so I think we could just document thatlanguage_versionsupport requires yourjuliato be from juliaup.With these changes, JuliaLang/Pkg.jl#4329 can run successfully.