refactor(core): convert ProfilerEvent enum to const object#68152
Open
JeanMeche wants to merge 1 commit intoangular:mainfrom
Open
refactor(core): convert ProfilerEvent enum to const object#68152JeanMeche wants to merge 1 commit intoangular:mainfrom
ProfilerEvent enum to const object#68152JeanMeche wants to merge 1 commit intoangular:mainfrom
Conversation
TS Enums usually bear a weight penalty because of the 2-way mapping they create. In the case of `ProfilerEvent`, it is only as a mapped object so we can convert it to a const object without losing any functionality.
4d7fcd1 to
1b18370
Compare
ProfilerEvent.ProfilerEvent enum to const object
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TS Enums usually bear a weight penalty because of the 2-way mapping they create.
In the case of
ProfilerEvent, it is only as a mapped object so we can convert it to a const object without losing any functionality.