docs(docs-infra): adjust close button spacing in mobile navigation#68160
Open
erkamyaman wants to merge 1 commit intoangular:mainfrom
Open
docs(docs-infra): adjust close button spacing in mobile navigation#68160erkamyaman wants to merge 1 commit intoangular:mainfrom
erkamyaman wants to merge 1 commit intoangular:mainfrom
Conversation
Contributor
Author
|
@JeanMeche we might need rerun the preview test, i believe it failed |
|
Deployed adev-preview for 10bcbda to: https://ng-dev-previews-fw--pr-angular-angular-68160-adev-prev-h2zxfisl.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
Contributor
Author
@JeanMeche all good now, thx! |
Use relative positioning to offset the close button from the top edge without affecting the layout of surrounding elements.
10bcbda to
7e4e9df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use relative positioning to offset the close button from the top edge without affecting the layout of surrounding elements.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
On mobile, the close button in the navigation panel sits too close to the top edge, making it look visually off.
Issue Number: N/A
What is the new behavior?
The close button is offset from the top edge using relative positioning, improving visual spacing without affecting the layout of surrounding elements.
Before vs After
Does this PR introduce a breaking change?
Other information