feat(core): Update Testability to use PendingTasks for stability indi…#68187
Draft
atscott wants to merge 1 commit intoangular:mainfrom
Draft
feat(core): Update Testability to use PendingTasks for stability indi…#68187atscott wants to merge 1 commit intoangular:mainfrom
atscott wants to merge 1 commit intoangular:mainfrom
Conversation
ab43a14 to
dc223c5
Compare
…cator Since angular/angular@12181b9, zone stability contributes to the PendingTasks. There is now a single source of truth for application stability tracked in PendingTasks. This change makes protractor's whenStable compatible with zoneless. The `Router` and `HttpClient` also contribute to stability using the `PendingTasks` injectable. There will likely be more updates in the future to have more features contribute to stableness in a zoneless compatible way. This update uses PendingTasks for stability by default when ZoneJS is not present or can be enabled with an option when ZoneJS is present (but otherwise ignored with ZoneJS). fixes angular#68180
dc223c5 to
88e9e07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cator
Since 12181b9, zone stability
contributes to the PendingTasks. There is now a single source of truth for application stability tracked in PendingTasks. This change makes protractor's whenStable compatible with zoneless. The
RouterandHttpClientalso contribute to stability using thePendingTasksinjectable. There will likely be more updates in the future to have more features contribute to stableness in a zoneless compatible way.This update uses PendingTasks for stability by default when ZoneJS is not present or can be enabled with an option when ZoneJS is present (but otherwise ignored with ZoneJS).
fixes #68180