Skip to content

fix: emojis appearing black and white in Chromium 96#33683

Merged
deepak1556 merged 1 commit into16-x-yfrom
miniak/fix-black-and-white-emojis-16-x-y
Apr 11, 2022
Merged

fix: emojis appearing black and white in Chromium 96#33683
deepak1556 merged 1 commit into16-x-yfrom
miniak/fix-black-and-white-emojis-16-x-y

Conversation

@miniak
Copy link
Copy Markdown
Contributor

@miniak miniak commented Apr 8, 2022

Description of Change

https://newpulselabs.com/emoji-black-white-chrome/

If you have an emoji inside of a bold text element, the emoji will show up monochrome/black & white instead of its normal colour.

Fixes: https://bugs.chromium.org/p/chromium/issues/detail?id=1266022
Backport: https://skia-review.googlesource.com/c/skia/+/482076

To repro, just add this to the document:

<p style="font-weight: bold;">😀 😃 😄 😁 😆 😅 😂 🤣 🥲 ☺️ 😊 😇 🙂 🙃 😉 😌 😍 🥰 😘 😗 😙 😚 😋 😛 😝 😜 🤪 🤨 🧐 🤓 😎 🥸 🤩 🥳 😏 😒 😞 😔 😟 😕 🙁 ☹️ 😣 😖 😫 😩 🥺 😢 😭 😤 😠 😡 🤬 🤯 😳 🥵 🥶 😱 😨 😰 😥 😓 🤗 🤔 🤭 🤫 🤥 😶 😐 😑 😬 🙄 😯 😦 😧 😮 😲 🥱 😴 🤤 😪 😵 🤐 🥴 🤢 🤮 🤧 😷 🤒 🤕 🤑 🤠 😈 👿 👹 👺 🤡 💩 👻 💀 ☠️ 👽 👾 🤖 🎃 😺 😸 😹 😻 😼 😽 🙀 😿 😾</p>

Before:
Screen Shot 2022-04-09 at 12 12 58 AM
After:
Screen Shot 2022-04-09 at 12 13 29 AM

Checklist

Release Notes

Notes: Fixed emojis appearing black and white in Chromium 96.

@miniak miniak added semver/patch backwards-compatible bug fixes backport-check-skip Skip trop's backport validity checking labels Apr 8, 2022
@miniak miniak requested a review from a team as a code owner April 8, 2022 17:14
@miniak miniak self-assigned this Apr 8, 2022
@miniak miniak requested a review from a team as a code owner April 8, 2022 17:14
@miniak miniak changed the title fix: Emojis appearing black and white in Chrome 96 fix: emojis appearing black and white in Chrome 96 Apr 8, 2022
@miniak miniak marked this pull request as draft April 8, 2022 17:27
@miniak miniak marked this pull request as ready for review April 8, 2022 22:00
@miniak miniak changed the title fix: emojis appearing black and white in Chrome 96 fix: emojis appearing black and white in Chromium 96 Apr 8, 2022
@deepak1556 deepak1556 merged commit 7be0d42 into 16-x-y Apr 11, 2022
@deepak1556 deepak1556 deleted the miniak/fix-black-and-white-emojis-16-x-y branch April 11, 2022 15:49
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Apr 11, 2022

Release Notes Persisted

Fixed emojis appearing black and white in Chromium 96.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

16-x-y backport-check-skip Skip trop's backport validity checking semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants