Database once() should only fire once by schmidt-sebastian · Pull Request #4864 · firebase/firebase-js-sdk

schmidt-sebastian · 2021-05-04T20:37:37Z

The way once() was implemented led to some level of recursion if the user updated the value inside the once callback. This update would get executed synchronously, which could trigger new invocations of the once() callback before it was unregistered.

Repo: https://jsbin.com/xofinop/4/edit?html,js,console

changeset-bot · 2021-05-04T20:37:39Z

🦋 Changeset detected

Latest commit: 3aad259

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
@firebase/database	Patch
firebase	Patch
@firebase/rules-unit-testing	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…into mrschmidt/once

google-oss-bot · 2021-05-04T21:07:14Z

Binary Size Report

Affected SDKs

@firebase/analytics

Type Base (d095ad3) Head (627537bc) Diff

esm2017 ? 18.7 kB ? (?)

main ? 24.2 kB ? (?)

module ? 23.4 kB ? (?)
@firebase/api-documenter

Type Base (d095ad3) Head (627537bc) Diff

main ? 3.72 kB ? (?)

`@firebase/app`

Type	Base (`d095ad3`)	Head (627537bc)	Diff
browser	?	10.9 kB	? (?)
esm2017	?	9.63 kB	? (?)
lite	?	8.95 kB	? (?)
lite-esm2017	?	7.93 kB	? (?)
main	?	9.99 kB	? (?)
module	?	10.9 kB	? (?)
react-native	?	9.70 kB	? (?)

@firebase/auth

Type Base (d095ad3) Head (627537bc) Diff

browser ? 181 kB ? (?)

main ? 181 kB ? (?)

module ? 181 kB ? (?)
@firebase/component

Type Base (d095ad3) Head (627537bc) Diff

browser ? 7.24 kB ? (?)

esm2017 ? 5.55 kB ? (?)

main ? 7.57 kB ? (?)

module ? 7.24 kB ? (?)
@firebase/database

Type Base (d095ad3) Head (627537bc) Diff

browser ? 296 kB ? (?)

esm2017 ? 264 kB ? (?)

main ? 298 kB ? (?)

module ? 296 kB ? (?)
@firebase/database-compat

Type Base (d095ad3) Head (627537bc) Diff

browser ? 86.3 kB ? (?)

main ? 102 kB ? (?)

module ? 86.3 kB ? (?)
@firebase/database-exp

Type Base (d095ad3) Head (627537bc) Diff

browser ? 246 kB ? (?)

main ? 278 kB ? (?)

module ? 246 kB ? (?)
@firebase/firestore

Type Base (d095ad3) Head (627537bc) Diff

browser ? 283 kB ? (?)

esm2017 ? 226 kB ? (?)

main ? 530 kB ? (?)

module ? 283 kB ? (?)

react-native ? 226 kB ? (?)
@firebase/firestore-compat

Type Base (d095ad3) Head (627537bc) Diff

browser ? 28.6 kB ? (?)

main ? 37.6 kB ? (?)

module ? 28.6 kB ? (?)

react-native ? 28.3 kB ? (?)
@firebase/firestore-exp

Type Base (d095ad3) Head (627537bc) Diff

browser ? 223 kB ? (?)

main ? 506 kB ? (?)

module ? 223 kB ? (?)

react-native ? 224 kB ? (?)
@firebase/firestore-lite

Type Base (d095ad3) Head (627537bc) Diff

browser ? 72.0 kB ? (?)

main ? 146 kB ? (?)

module ? 72.0 kB ? (?)

react-native ? 72.2 kB ? (?)
@firebase/firestore/bundle

Type Base (d095ad3) Head (627537bc) Diff

browser ? 289 kB ? (?)

esm2017 ? 176 kB ? (?)

main ? 526 kB ? (?)

module ? 289 kB ? (?)

react-native ? 176 kB ? (?)
@firebase/firestore/memory

Type Base (d095ad3) Head (627537bc) Diff

browser ? 215 kB ? (?)

esm2017 ? 172 kB ? (?)

main ? 324 kB ? (?)

module ? 215 kB ? (?)

react-native ? 172 kB ? (?)
@firebase/firestore/memory-bundle

Type Base (d095ad3) Head (627537bc) Diff

browser ? 224 kB ? (?)

esm2017 ? 176 kB ? (?)

main ? 321 kB ? (?)

module ? 224 kB ? (?)

react-native ? 176 kB ? (?)
@firebase/functions

Type Base (d095ad3) Head (627537bc) Diff

browser ? 10.6 kB ? (?)

esm2017 ? 8.15 kB ? (?)

main ? 11.0 kB ? (?)

module ? 10.6 kB ? (?)
@firebase/installations

Type Base (d095ad3) Head (627537bc) Diff

esm2017 ? 16.6 kB ? (?)

main ? 22.2 kB ? (?)

module ? 21.6 kB ? (?)
@firebase/logger

Type Base (d095ad3) Head (627537bc) Diff

esm2017 ? 3.25 kB ? (?)

main ? 5.38 kB ? (?)

module ? 4.65 kB ? (?)
@firebase/messaging

Type Base (d095ad3) Head (627537bc) Diff

esm2017 ? 26.2 kB ? (?)

main ? 34.9 kB ? (?)

module ? 34.4 kB ? (?)
@firebase/performance

Type Base (d095ad3) Head (627537bc) Diff

browser ? 27.7 kB ? (?)

esm2017 ? 25.9 kB ? (?)

main ? 28.0 kB ? (?)

module ? 27.7 kB ? (?)
@firebase/polyfill

Type Base (d095ad3) Head (627537bc) Diff

main ? 747 B ? (?)

module ? 705 B ? (?)
@firebase/remote-config

Type Base (d095ad3) Head (627537bc) Diff

browser ? 22.4 kB ? (?)

esm2017 ? 17.4 kB ? (?)

main ? 23.0 kB ? (?)

module ? 22.4 kB ? (?)
@firebase/rules-unit-testing

Type Base (d095ad3) Head (627537bc) Diff

main ? 12.6 kB ? (?)
@firebase/storage

Type Base (d095ad3) Head (627537bc) Diff

browser ? 63.4 kB ? (?)

esm2017 ? 54.6 kB ? (?)

main ? 63.8 kB ? (?)

module ? 63.4 kB ? (?)
@firebase/storage-compat

Type Base (d095ad3) Head (627537bc) Diff

browser ? 10.2 kB ? (?)

main ? 29.1 kB ? (?)

module ? 10.2 kB ? (?)
@firebase/storage-exp

Type Base (d095ad3) Head (627537bc) Diff

browser ? 51.5 kB ? (?)

main ? 52.6 kB ? (?)

module ? 51.5 kB ? (?)
@firebase/util

Type Base (d095ad3) Head (627537bc) Diff

browser ? 21.2 kB ? (?)

esm2017 ? 20.0 kB ? (?)

main ? 25.8 kB ? (?)

module ? 21.2 kB ? (?)
@firebase/webchannel-wrapper

Type Base (d095ad3) Head (627537bc) Diff

esm2017 ? 39.5 kB ? (?)

main ? 46.9 kB ? (?)

module ? 40.8 kB ? (?)

`firebase`

Click to show 15 binary size changes.

Type	Base (`d095ad3`)	Head (627537bc)	Diff
firebase-analytics.js	?	35.8 kB	? (?)
firebase-app.js	?	21.2 kB	? (?)
firebase-auth.js	?	177 kB	? (?)
firebase-database.js	?	187 kB	? (?)
firebase-firestore.js	?	332 kB	? (?)
firebase-firestore.memory.js	?	266 kB	? (?)
firebase-functions.js	?	10.7 kB	? (?)
firebase-installations.js	?	19.3 kB	? (?)
firebase-messaging.js	?	41.0 kB	? (?)
firebase-performance-standalone.es2017.js	?	72.9 kB	? (?)
firebase-performance-standalone.js	?	49.2 kB	? (?)
firebase-performance.js	?	38.3 kB	? (?)
firebase-remote-config.js	?	36.9 kB	? (?)
firebase-storage.js	?	41.6 kB	? (?)
firebase.js	?	874 kB	? (?)

Test Logs

Head (627537bc): https://github.com/firebase/firebase-js-sdk/actions/runs/811343855

google-oss-bot · 2021-05-04T21:08:09Z

Size Analysis Report

Affected Products

No changes between base commit (d095ad3) and head commit (627537bc).

Test Logs

Base (d095ad3): https://github.com/firebase/firebase-js-sdk/actions/runs/811343514
Head (627537bc): https://github.com/firebase/firebase-js-sdk/actions/runs/811343855

schmidt-sebastian · 2021-05-07T15:23:51Z

@hsubox76 Do you have time to take a look at this?

Database once() should only fire once

665ca2b

schmidt-sebastian requested a review from jsdt as a code owner May 4, 2021 20:37

schmidt-sebastian requested a review from hsubox76 May 4, 2021 20:38

schmidt-sebastian assigned hsubox76 May 4, 2021

schmidt-sebastian added the api: database label May 4, 2021

schmidt-sebastian added 3 commits May 4, 2021 14:39

Create many-turtles-try.md

5ef8a6f

Lint

523da7c

Merge branch 'mrschmidt/once' of github.com:firebase/firebase-js-sdk …

3aad259

…into mrschmidt/once

jsdt approved these changes May 5, 2021

View reviewed changes

hsubox76 approved these changes May 10, 2021

View reviewed changes

hsubox76 merged commit 5b202f8 into master May 11, 2021

hsubox76 deleted the mrschmidt/once branch May 11, 2021 21:43

google-oss-bot mentioned this pull request May 12, 2021

Version Packages #4900

Merged

firebase locked and limited conversation to collaborators Jun 11, 2021

Conversation

schmidt-sebastian commented May 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented May 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

google-oss-bot commented May 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Report

Affected SDKs

@firebase/analytics

@firebase/api-documenter

@firebase/app

@firebase/auth

@firebase/component

@firebase/database

@firebase/database-compat

@firebase/database-exp

@firebase/firestore

@firebase/firestore-compat

@firebase/firestore-exp

@firebase/firestore-lite

@firebase/firestore/bundle

@firebase/firestore/memory

@firebase/firestore/memory-bundle

@firebase/functions

@firebase/installations

@firebase/logger

@firebase/messaging

@firebase/performance

@firebase/polyfill

@firebase/remote-config

@firebase/rules-unit-testing

@firebase/storage

@firebase/storage-compat

@firebase/storage-exp

@firebase/util

@firebase/webchannel-wrapper

firebase

Test Logs

Uh oh!

google-oss-bot commented May 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report

Affected Products

Test Logs

Uh oh!

schmidt-sebastian commented May 7, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

schmidt-sebastian commented May 4, 2021 •

edited

Loading

changeset-bot bot commented May 4, 2021 •

edited

Loading

google-oss-bot commented May 4, 2021 •

edited

Loading

`@firebase/analytics`

`@firebase/api-documenter`

`@firebase/app`

`@firebase/auth`

`@firebase/component`

`@firebase/database`

`@firebase/database-compat`

`@firebase/database-exp`

`@firebase/firestore`

`@firebase/firestore-compat`

`@firebase/firestore-exp`

`@firebase/firestore-lite`

`@firebase/firestore/bundle`

`@firebase/firestore/memory`

`@firebase/firestore/memory-bundle`

`@firebase/functions`

`@firebase/installations`

`@firebase/logger`

`@firebase/messaging`

`@firebase/performance`

`@firebase/polyfill`

`@firebase/remote-config`

`@firebase/rules-unit-testing`

`@firebase/storage`

`@firebase/storage-compat`

`@firebase/storage-exp`

`@firebase/util`

`@firebase/webchannel-wrapper`

`firebase`

google-oss-bot commented May 4, 2021 •

edited

Loading