Remove use of Str::slug when building reverse geocoding cache key#204
Merged
mikebronner merged 1 commit intogeocoder-php:masterfrom Apr 18, 2026
Merged
Remove use of Str::slug when building reverse geocoding cache key#204mikebronner merged 1 commit intogeocoder-php:masterfrom
Str::slug when building reverse geocoding cache key#204mikebronner merged 1 commit intogeocoder-php:masterfrom
Conversation
Use of `Str::slug` when building reverse geocoding cache key was redundant as the characters allowed in the cache are already controller. This fixes a bug where geolocation with opposites lat/lngs (45/73 vs -45/73 vs 45/-73 vs -45/-73) would all have the same cache key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use of
Str::slugwhen building reverse geocoding cache key was redundant as the characters allowed in the cache are already controller. This fixes a bug where geolocation with opposites lat/lngs (45/73 vs -45/73 vs 45/-73 vs -45/-73) would all have the same cache key.This fixes issue #203.