Added curl ntlm auth support#1569
Added curl ntlm auth support#1569sagikazarmark merged 1 commit intoguzzle:masterfrom miguelbalboa:master
Conversation
|
Same as #1381 but with doc and test. I'm wondering if StreamHandler::createStream is the right place to through exception if we try to use NTLM with PHP Stream. Something like: // Microsoft NTLM authentication only supported with curl handler
if (isset($options['auth'])) {
if (is_array($options['auth']) && isset($options['auth'][2])) {
if ('ntlm' == $options['auth'][2]) {
throw new \InvalidArgumentException('Microsoft NTLM authentication only supported with curl handler');
}
}
}Or in Client::applyOptions ? |
|
Thanks for your contribution. Can you please squash your commits (and rebase from master)?
This shouldn't be there
Since in I would also move all the conditions into one if: same amount of logical expressions to evaluate, but less branching and more readable code. Do you think you can finish this @miguelbalboa ? |
|
@sagikazarmark |
|
@sagikazarmark do you know when this will be merged? |
|
I don't have an exact ETA yet. Current aim is to get 6.3 around end of February. |
|
Thanks for your work on this, sorry for the painfully long wait. |
No description provided.