Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase#1953
Merged
sagikazarmark merged 2 commits intoguzzle:masterfrom Feb 5, 2018
carusogabriel:phpunit
Merged
Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase#1953sagikazarmark merged 2 commits intoguzzle:masterfrom carusogabriel:phpunit
sagikazarmark merged 2 commits intoguzzle:masterfrom
carusogabriel:phpunit
Conversation
Member
|
Thanks a lot for your PR. I believe Can you check why the tests are broken? |
Contributor
Author
|
@sagikazarmark I'll work on that |
Contributor
Author
|
@sagikazarmark Tests fixed, and now we support I just need to set Any doubt, I used this article from @sebastianbergmann to help me in this update. |
|
Just fyi, there is no reason to support 4.0 version, this is dev dependency. Thus not installed anywhere but in this project. |
Member
|
@carusogabriel many thanks for your work! @TomasVotruba we still officially support PHP 5.5 and as of PHPUnit 5.0 the minimum PHP requirement is 5.6. So we still need PHPUnit 4.x for a while...but hopefully, not so long. |
|
👍 |
This was referenced Mar 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use the
PHPUnit\Framework\TestCasenotation instead ofPHPUnit_Framework_TestCasewhile extending our TestCases. This will help us migrate to PHPUnit 6, that no longer support snake case class names.I just need to bump PHPUnit version to
^4.8.35and^5.7, that support this namespace.