Custom option for cURL multi handler#2287
Merged
Nyholm merged 2 commits intoguzzle:masterfrom Oct 23, 2019
Merged
Conversation
kkopachev
reviewed
Jun 10, 2019
darvids0n
suggested changes
Jul 8, 2019
darvids0n
approved these changes
Jul 8, 2019
27df4df to
8010664
Compare
Collaborator
Author
|
So tests are failing because of the issues in |
|
@sagikazarmark ping |
fe66dcf to
89b4a6e
Compare
Collaborator
Author
|
@sagikazarmark, could you take a look at this for the next release? |
Nyholm
approved these changes
Oct 18, 2019
Member
Nyholm
left a comment
There was a problem hiding this comment.
Thank you for this PR.
I think this looks good. But I would like an other review on it.
89b4a6e to
17a6117
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom options for cURL multi handler, allowing to configure a handle from
curl_multi_init(). Something like'curl'request options, to fix #2248, for example.