Skip to content

Update proto files to the latest definitions. Add some new versions.#1969

Merged
k8s-ci-robot merged 2 commits intokubernetes-client:masterfrom
brendandburns:proto
Nov 15, 2021
Merged

Update proto files to the latest definitions. Add some new versions.#1969
k8s-ci-robot merged 2 commits intokubernetes-client:masterfrom
brendandburns:proto

Conversation

@brendandburns
Copy link
Copy Markdown
Contributor

@brendandburns brendandburns commented Nov 5, 2021

cc @yue9944882

I'm not sure anyone uses the proto definitions, but they hadn't been updated in a long time. I'm amazed it still worked :P

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 5, 2021
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 5, 2021
@yue9944882
Copy link
Copy Markdown
Member

@brendandburns great! can you run the formatter so that we can proceed to merge?

Copy link
Copy Markdown
Member

@yue9944882 yue9944882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [brendandburns,yue9944882]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fbb8557 into kubernetes-client:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants