Skip to content

chore: 'adopt' --> 'temurin'#1980

Merged
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
sullis:temurin-jdk
Nov 24, 2021
Merged

chore: 'adopt' --> 'temurin'#1980
k8s-ci-robot merged 1 commit intokubernetes-client:masterfrom
sullis:temurin-jdk

Conversation

@sullis
Copy link
Copy Markdown
Contributor

@sullis sullis commented Nov 13, 2021 •
edited
Loading

https://github.com/actions/setup-java/blob/main/README.md

NOTE: Adopt OpenJDK got moved to Eclipse Temurin and won't be 
updated anymore. It is highly recommended to migrate workflows 
from adopt to temurin to keep receiving software and security updates.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2021
@yue9944882
Copy link
Copy Markdown
Member

yue9944882 commented Nov 15, 2021

Available versions: 17.0.1+12, 17.0.0+35, 16.0.2+7, 11.0.13+8, 11.0.12+7, 8.0.312+7, 8.0.302+8

thanks @sullis, i think we need to remove JDK9 and the other unsupported versions from this list to switch to Temurin

@brendandburns
Copy link
Copy Markdown
Contributor

brendandburns commented Nov 19, 2021

I'd suggest we remove both JDK9, JDK10 and JDK16 and we add JDK17

We should track the LTS JDKs + whatever the current development version is (will be JDK18 but it's not out yet)

@brendandburns brendandburns mentioned this pull request Nov 19, 2021
Merged
@brendandburns
Copy link
Copy Markdown
Contributor

brendandburns commented Nov 19, 2021

I just sent #1999 to update our matrix.

@brendandburns
Copy link
Copy Markdown
Contributor

brendandburns commented Nov 23, 2021

@sullis if you rebase this I think it can merge.

@sullis
Copy link
Copy Markdown
Contributor Author

sullis commented Nov 23, 2021

@sullis if you rebase this I think it can merge.

Rebased.

yue9944882
yue9944882 reviewed Nov 24, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@yue9944882 yue9944882 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 24, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Nov 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sullis, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2021
@k8s-ci-robot k8s-ci-robot merged commit e8b4d60 into kubernetes-client:master Nov 24, 2021
@sullis sullis deleted the temurin-jdk branch December 19, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yue9944882 yue9944882 yue9944882 left review comments

@brendandburns brendandburns Awaiting requested review from brendandburns

Assignees

@yue9944882 yue9944882

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sullis @yue9944882 @brendandburns @k8s-ci-robot