Emit stack trace when TrackExceptionsAsExceptionTelemetry is set to f…#2065
Merged
cijothomas merged 7 commits intomicrosoft:developfrom Sep 22, 2020
RamjotSingh:ramjsing/develop-EmitStackTraceInTrace
Merged
Emit stack trace when TrackExceptionsAsExceptionTelemetry is set to f…#2065cijothomas merged 7 commits intomicrosoft:developfrom RamjotSingh:ramjsing/develop-EmitStackTraceInTrace
cijothomas merged 7 commits intomicrosoft:developfrom
RamjotSingh:ramjsing/develop-EmitStackTraceInTrace
Conversation
Member
Author
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 2065 in repo microsoft/ApplicationInsights-dotnet |
Contributor
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
cijothomas
reviewed
Sep 21, 2020
cijothomas
reviewed
Sep 22, 2020
cijothomas
approved these changes
Sep 22, 2020
Contributor
cijothomas
left a comment
There was a problem hiding this comment.
LGTM.
Left a small comment in testing.
cijothomas
approved these changes
Sep 22, 2020
Contributor
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was referenced Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Issue #2064.
Changes
ILogger logs StackTraces in TraceTelemetry when
TrackExceptionsAsExceptionTelemetryflag is set tofalse.Checklist
The PR will trigger build, unit tests, and functional tests automatically. Please follow these instructions to build and test locally.
Notes for authors:
Notes for reviewers:
/AzurePipelines runwill queue all builds/AzurePipelines run <pipeline-name>will queue a specific build